New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8266017: Refactor the *klass::array_klass_impl code to separate the non-exception-throwing API #3711
Conversation
…on-exception-throwing API
👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into |
@dholmes-ora The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
/label remove hotspot |
@dholmes-ora |
/label add hotspot-runtime |
@dholmes-ora |
Mailing list message from David Holmes on hotspot-runtime-dev: Forwarded from hotspot-dev (I didn't see the mailing list selection in David |
1 similar comment
Mailing list message from David Holmes on hotspot-runtime-dev: Forwarded from hotspot-dev (I didn't see the mailing list selection in David |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice cleanup. I wish we'd done this years ago!
@dholmes-ora This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Mailing list message from David Holmes on hotspot-runtime-dev: On 28/04/2021 6:50 am, Ioi Lam wrote:
Yes I think you are right - no need to inherit the top-level delegating Thanks for looking at this Ioi and Coleen! David |
…ride those methods directly, getting rid of the impl versions,
@dholmes-ora this pull request can not be integrated into git checkout 8266017
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a small nit about comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest version looks good.
/integrate |
@dholmes-ora Since your change was applied there have been 39 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 23180f8. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
We currently have array_klass() and array_klass_or_null(), where the former can throw exceptions and the latter can not. But they both delegate to:
array_klass_impl(bool or_null, TRAPS)
which combines both the exception-throwing and non-exception-throwing code into one method declared with TRAPS. To make progress with the change of TRAPS to JavaThread (JDK-8252685) we need to separate these code paths into distinct methods.
Testing: tiers 1-3 (in progress)
Thanks,
David
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3711/head:pull/3711
$ git checkout pull/3711
Update a local copy of the PR:
$ git checkout pull/3711
$ git pull https://git.openjdk.java.net/jdk pull/3711/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3711
View PR using the GUI difftool:
$ git pr show -t 3711
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3711.diff