Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266055: ZGC: ZHeap::print_extended_on() doesn't disable deferred delete #3717

Closed

Conversation

@pliden
Copy link
Contributor

@pliden pliden commented Apr 27, 2021

In ZHeap::print_extended_on(), the last call to _page_allocator.enable_deferred_delete() should be _page_allocator.disable_deferred_delete().


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266055: ZGC: ZHeap::print_extended_on() doesn't disable deferred delete

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3717/head:pull/3717
$ git checkout pull/3717

Update a local copy of the PR:
$ git checkout pull/3717
$ git pull https://git.openjdk.java.net/jdk pull/3717/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3717

View PR using the GUI difftool:
$ git pr show -t 3717

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3717.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 27, 2021

👋 Welcome back pliden! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Apr 27, 2021
fisk
fisk approved these changes Apr 27, 2021
Copy link
Contributor

@fisk fisk left a comment

Looks fantastic.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 27, 2021

@pliden The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the hotspot-gc label Apr 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 27, 2021

@pliden This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266055: ZGC: ZHeap::print_extended_on() doesn't disable deferred delete

Reviewed-by: eosterlund, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • dc323a9: 8263421: Module image file is opened twice during VM startup
  • fbfd4ea: 8265914: Duplicated NotANode and not_a_node
  • 9481fad: 8163367: Test javax/swing/JComboBox/8033069/bug8033069NoScrollBar.java javax/swing/JComboBox/8033069/bug8033069ScrollBar.java fails intermittently
  • 9adbf15: 8265995: Shenandoah: Move ShenandoahInitMarkRootsClosure close to its use
  • 879a77f: 8265757: stack-use-after-scope in perfMemory_posix.cpp get_user_name_slow()
  • e4be968: 8265980: Fix systemDictionary and loaderConstraints printing
  • f6e26f6: 8265756: AArch64: initialize memory allocated for locals according to Windows AArch64 stack page growth requirement in template interpreter
  • 0a4c338: 8263432: javac may report an invalid package/class clash on case insensitive filesystems

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Apr 27, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 27, 2021

Webrevs

Loading

@pliden
Copy link
Contributor Author

@pliden pliden commented Apr 28, 2021

Thanks @fisk and @albertnetymk for reviewing!

/integrate

Loading

@openjdk openjdk bot closed this Apr 28, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 28, 2021

@pliden Since your change was applied there have been 32 commits pushed to the master branch:

  • ce48f04: 8198617: java/awt/Focus/6382144/EndlessLoopTest.java fails on mac
  • 0438cea: 8136517: [macosx]Test java/awt/Focus/8073453/AWTFocusTransitionTest.java fails on MacOSX
  • 6b5e5d7: 8266181: compiler/eliminateAutobox/TestEliminateBoxInDebugInfo should be in driver mode
  • 81b1502: 8266161: mark hotspot compiler/rtm tests which ignore VM flags
  • 4a8324d: 8266180: compiler/vectorapi/TestVectorErgonomics should be run in driver mode
  • 0601aba: 8266175: mark hotspot compiler/jsr292 tests which ignore VM flags
  • 69ad8ac: 8266169: mark hotspot compiler/jvmci tests which ignore VM flags
  • 1a2a570: 8266166: mark hotspot compiler/linkage tests which ignore VM flags
  • 5ee58b0: 8266164: mark hotspot compiler/loopstripmining tests which ignore VM flags
  • 1a37bce: 8263779: SSLEngine reports NEED_WRAP continuously without producing any further output
  • ... and 22 more: https://git.openjdk.java.net/jdk/compare/82b371956a3fd3fbd2a9079477945d5c56e2d945...master

Your commit was automatically rebased without conflicts.

Pushed as commit 2201e11.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@pliden pliden deleted the 8266055_disable_deferred_delete branch Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants