8266088: compiler/arguments/TestPrintOptoAssemblyLineNumbers test should user driver mode

[iignatev]

Hi all,

could you please review this tiny patch for TestPrintOptoAssemblyLineNumbers test?
from JBS:

compiler/arguments/TestPrintOptoAssemblyLineNumbers class is a driver class that spawns a new JVM and validates its output, there is no need for the JVM which executes TestPrintOptoAssemblyLineNumbers to be run w/ all vm flags.

besides addressing this, the patch also removes /compiler/patches from @library as it's not needed and fixes code style here and there.

testing:

• compiler/arguments/TestPrintOptoAssemblyLineNumbers on {linux,windows,macosx}-x64-debug

Thanks,
-- Igor

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8266088: compiler/arguments/TestPrintOptoAssemblyLineNumbers test should user driver mode

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3726/head:pull/3726
$ git checkout pull/3726

Update a local copy of the PR:
$ git checkout pull/3726
$ git pull https://git.openjdk.java.net/jdk pull/3726/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3726

View PR using the GUI difftool:
$ git pr show -t 3726

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3726.diff

[bridgekeeper]

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iignatev The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (b5a52b94)
• 01: Full - Incremental (d4b342a9)
• 00: Full (1e37f7b3)

[vnkozlov]

Add Oracle copyright line.

[vnkozlov]

Missed space between ){

[iignatev]

staring more at this test, I've noticed a few other things which should be improved:

• the test didn't use OutputAnaluzer::*should* method to check that the output contains the desired line. so in case of failure, we won't have all information about the subprocess
• it didn't check the subprocess' exit code
• the file is sensitive to line numbers but didn't have the comment which we use to mark and track such files

[vnkozlov]

Good.

[openjdk]

@iignatev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266088: compiler/arguments/TestPrintOptoAssemblyLineNumbers test should user driver mode

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• f560b89: 8264873: Dependencies: Split ClassHierarchyWalker
• 0a88f0a: 8255915: jdk/incubator/vector/AddTest.java timed out
• ab2aec2: 8265938: C2's conditional move optimization does not handle top Phi

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[iignatev]

thanks, Vladimir.

/integrate

[openjdk]

@iignatev Since your change was applied there have been 3 commits pushed to the master branch:

• f560b89: 8264873: Dependencies: Split ClassHierarchyWalker
• 0a88f0a: 8255915: jdk/incubator/vector/AddTest.java timed out
• ab2aec2: 8265938: C2's conditional move optimization does not handle top Phi

Your commit was automatically rebased without conflicts.

Pushed as commit 7f4a9f6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.