Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266169: mark hotspot compiler/jvmci tests which ignore VM flags #3739

Closed
wants to merge 2 commits into from

Conversation

iignatev
Copy link
Member

@iignatev iignatev commented Apr 28, 2021

Hi all,

could you please review this small and trivial patch that adds @requires vm.flagless to compiler/jvmci tests that ignore VM flags?

Thanks,
-- Igor


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266169: mark hotspot compiler/jvmci tests which ignore VM flags

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3739/head:pull/3739
$ git checkout pull/3739

Update a local copy of the PR:
$ git checkout pull/3739
$ git pull https://git.openjdk.java.net/jdk pull/3739/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3739

View PR using the GUI difftool:
$ git pr show -t 3739

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3739.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 28, 2021

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8266169 8266169: mark hotspot compiler/jvmci tests which ignore VM flags Apr 28, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 28, 2021
@openjdk
Copy link

openjdk bot commented Apr 28, 2021

@iignatev The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Apr 28, 2021
@mlbridge
Copy link

mlbridge bot commented Apr 28, 2021

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@openjdk
Copy link

openjdk bot commented Apr 28, 2021

@iignatev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266169: mark hotspot compiler/jvmci tests which ignore VM flags

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • e144104: 8262908: JFR: Allow JFR to stream events from a known repository path
  • 30b1354: 8266153: mark hotspot compiler/onSpinWait tests which ignore VM flags
  • eeddb30: 8266150: mark hotspot compiler/arguments tests which ignore VM flags
  • feb18d2: 8266149: mark hotspot compiler/startup tests which ignore VM flags
  • eb72950: 8266154: mark hotspot compiler/oracle tests which ignore VM flags

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 28, 2021
@iignatev
Copy link
Member Author

thank you, Vladimir.

/integrate

@openjdk openjdk bot closed this Apr 28, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 28, 2021
@openjdk
Copy link

openjdk bot commented Apr 28, 2021

@iignatev Since your change was applied there have been 9 commits pushed to the master branch:

  • 1a2a570: 8266166: mark hotspot compiler/linkage tests which ignore VM flags
  • 5ee58b0: 8266164: mark hotspot compiler/loopstripmining tests which ignore VM flags
  • 1a37bce: 8263779: SSLEngine reports NEED_WRAP continuously without producing any further output
  • 889d246: 8265917: Different values computed by C2 and interpreter/C1 for Math.pow(x, 2.0) on x86_32
  • e144104: 8262908: JFR: Allow JFR to stream events from a known repository path
  • 30b1354: 8266153: mark hotspot compiler/onSpinWait tests which ignore VM flags
  • eeddb30: 8266150: mark hotspot compiler/arguments tests which ignore VM flags
  • feb18d2: 8266149: mark hotspot compiler/startup tests which ignore VM flags
  • eb72950: 8266154: mark hotspot compiler/oracle tests which ignore VM flags

Your commit was automatically rebased without conflicts.

Pushed as commit 69ad8ac.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants