-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8252194: Add automated test for fix done in JDK-8218469 #374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back pbansal! A progress list of the required criteria for merging this PR into |
@pankaj-bansal The following label will be automatically applied to this pull request: When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the |
Mailing list message from Alexander Zuev on swing-dev: Hi Pankaj, ? in your test you have both * @requires (os.family == "linux") and if (!System.getProperty("os.name").startsWith("Linux")) { Isn't it a little bit overkill? Otherwise looks good. /Alex On 9/27/2020 9:51 AM, Pankaj Bansal wrote: -------------- next part -------------- |
Mailing list message from Pankaj Bansal on swing-dev: Hi Alex, Thanks for the review. On 27/09/20 11:27 PM, Alexander Zuev wrote:
This has been discussed earlier for some other test. The logic is that, Regards,
-------------- next part -------------- |
@pankaj-bansal This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 9 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@pankaj-bansal Since your change was applied there have been 14 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 1ae6b53. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Under JDK-8218469, fix was made to correct the rendering of JSlider as the Slider knob/head was not being rendered at all. The reason was that gtk3 changed the way styles are used. No automated test was written to verify the results. Current bug is to write the automated tests for the same.
I have verified that the test fails without the fix done for DK-8218469 and passes with the fix.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/374/head:pull/374
$ git checkout pull/374