Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252194: Add automated test for fix done in JDK-8218469 #374

Closed
wants to merge 1 commit into from

Conversation

pankaj-bansal
Copy link

@pankaj-bansal pankaj-bansal commented Sep 27, 2020

Under JDK-8218469, fix was made to correct the rendering of JSlider as the Slider knob/head was not being rendered at all. The reason was that gtk3 changed the way styles are used. No automated test was written to verify the results. Current bug is to write the automated tests for the same.
I have verified that the test fails without the fix done for DK-8218469 and passes with the fix.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252194: Add automated test for fix done in JDK-8218469

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/374/head:pull/374
$ git checkout pull/374

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 27, 2020

👋 Welcome back pbansal! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 27, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 27, 2020

@pankaj-bansal The following label will be automatically applied to this pull request: swing.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the swing label Sep 27, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 27, 2020

Webrevs

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 27, 2020

Mailing list message from Alexander Zuev on swing-dev:

Hi Pankaj,

? in your test you have both

* @requires (os.family == "linux")

and

if (!System.getProperty("os.name").startsWith("Linux")) {
System.out.println("This test is meant for Linux platform only");
return;
}

Isn't it a little bit overkill?

Otherwise looks good.

/Alex

On 9/27/2020 9:51 AM, Pankaj Bansal wrote:

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20200927/faeeb0c9/attachment.htm>

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 27, 2020

Mailing list message from Pankaj Bansal on swing-dev:

Hi Alex,

Thanks for the review.

On 27/09/20 11:27 PM, Alexander Zuev wrote:

Hi Pankaj,

? in your test you have both
* @requires (os.family == "linux")
and
if (!System.getProperty("os.name").startsWith("Linux")) {
System.out.println("This test is meant for Linux platform only");
return;
}
Isn't it a little bit overkill?

This has been discussed earlier for some other test. The logic is that,
if the test is run under jtreg, the test would not be run/scheduled at
all due to @requires tag on non-linux platforms. If the test is run as
standalone test, the test will start but the "if" condition should stop
the test.

Regards,
Pankaj

Otherwise looks good.

/Alex

On 9/27/2020 9:51 AM, Pankaj Bansal wrote:

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20200928/baa0bda6/attachment.htm>

mrserb
mrserb approved these changes Sep 28, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 28, 2020

@pankaj-bansal This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8252194: Add automated test for fix done in JDK-8218469

Reviewed-by: serb, jdv, kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 840aa2b: 8253424: Add support for running pre-submit testing using GitHub Actions
  • 8e87d46: 8252857: AArch64: Shenandoah C1 CAS is not sequentially consistent
  • c2692f8: 8225329: -XX:+PrintBiasedLockingStatistics causes crash during initia…
  • e9c1782: 8252752: Clear card table for old regions during scan in G1
  • 276fcee: 8252835: Revert fix for JDK-8246051
  • ca1ed16: 8253639: Change os::attempt_reserve_memory_at parameter order
  • fed3636: 8252219: C2: Randomize IGVN worklist for stress testing
  • 625a935: 8253638: Cleanup os::reserve_memory and remove MAP_FIXED
  • f014854: 8253624: gtest fails when run from make with read-only source directory

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 28, 2020
@pankaj-bansal
Copy link
Author

@pankaj-bansal pankaj-bansal commented Sep 28, 2020

/integrate

@openjdk openjdk bot closed this Sep 28, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 28, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 28, 2020

@pankaj-bansal Since your change was applied there have been 14 commits pushed to the master branch:

  • 77a0f39: 8253540: InterpreterRuntime::monitorexit should be a JRT_LEAF function
  • 0054c15: 8253435: Cgroup: 'stomping of _mount_path' crash if manually mounted cpusets exist
  • 8e338f6: 8253646: ZGC: Avoid overhead of sorting ZStatIterableValues on bootstrap
  • ec9bee6: 8253015: Aarch64: Move linux code out from generic CPU feature detection
  • 16b8c39: 8253053: Javadoc clean up in Authenticator and BasicAuthenicator
  • 840aa2b: 8253424: Add support for running pre-submit testing using GitHub Actions
  • 8e87d46: 8252857: AArch64: Shenandoah C1 CAS is not sequentially consistent
  • c2692f8: 8225329: -XX:+PrintBiasedLockingStatistics causes crash during initia…
  • e9c1782: 8252752: Clear card table for old regions during scan in G1
  • 276fcee: 8252835: Revert fix for JDK-8246051
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/7817963ce91384380fe65005a6c438b08b022bad...master

Your commit was automatically rebased without conflicts.

Pushed as commit 1ae6b53.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@pankaj-bansal pankaj-bansal deleted the JDK-8252194 branch Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated swing
4 participants