Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8203047: [macosx] java/awt/EventDispatchThread/HandleExceptionOnEDT/HandleExceptionOnEDT.java fails #3749

Closed
wants to merge 2 commits into from

Conversation

@prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Apr 28, 2021

This test was seen to be failing long time back citing "exception is not handled for modal dialog "
with stacktrace for some failiures seen to be

sun.awt.SunToolkit$OperationTimedOut: 10469
at sun.awt.X11.XToolkit.syncNativeQueue(XToolkit.java:2447)
at sun.awt.SunToolkit.realSync(SunToolkit.java:1574)
at sun.awt.SunToolkit.realSync(SunToolkit.java:1506)
at test.java.awt.regtesthelpers.Util.waitForIdle(Util.java:184)
at HandleExceptionOnEDT.main(HandleExceptionOnEDT.java:75)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:601)
at com.sun.javatest.regtest.MainWrapper$MainThread.run(MainWrapper.java:96)
at java.lang.Thread.run(Thread.java:722)
This relasync issue was fixed in 8196100 and this test is now passing consistently.
Even then, I have added a delay to test after the frame/dialog is visible in sync with similar other tests and also dispose off the frame/dialogs at the end in proper finally block.
Several iterations of test pass in all platforms.

@jayathirthrao can you please take a look?


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8203047: [macosx] java/awt/EventDispatchThread/HandleExceptionOnEDT/HandleExceptionOnEDT.java fails

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3749/head:pull/3749
$ git checkout pull/3749

Update a local copy of the PR:
$ git checkout pull/3749
$ git pull https://git.openjdk.java.net/jdk pull/3749/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3749

View PR using the GUI difftool:
$ git pr show -t 3749

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3749.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 28, 2021

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 28, 2021

@prsadhuk The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt label Apr 28, 2021
@openjdk openjdk bot added the rfr label Apr 28, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 28, 2021

Webrevs

@mrserb
Copy link
Member

@mrserb mrserb commented Apr 28, 2021

I think it is just luck that you did not get an exception, this bug is still there JDK-8072110. You can close this one as a duplicate.

@prsadhuk prsadhuk closed this Apr 28, 2021
@prsadhuk prsadhuk deleted the JDK-8203047 branch Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants