-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8266040: Lanai: Incorrect calculations of clipping boundaries #3758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adjust initial clipping values to correctly calculate shape clip boundary
👋 Welcome back avu! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
jtreg and JCK all test run is fine.
J2DDemo and SwingSet2 looks good.
Ran RenderPerfTest and saw improvement in ClipFlatOval/ClipFlatOvalAA from ~10FPS to ~14FPS in my machine.
@avu This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 155 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jayathirthrao) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
/sponsor |
@jayathirthrao @avu Since your change was applied there have been 155 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 87de5b7. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Adjust initial clipping values to correctly calculate shape clip boundary
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3758/head:pull/3758
$ git checkout pull/3758
Update a local copy of the PR:
$ git checkout pull/3758
$ git pull https://git.openjdk.java.net/jdk pull/3758/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3758
View PR using the GUI difftool:
$ git pr show -t 3758
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3758.diff