Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266206: Build failure after JDK-8264752 with older GCCs #3759

Closed

Conversation

@shipilev
Copy link
Contributor

@shipilev shipilev commented Apr 28, 2021

See the bug report for error log. It seems older GCCs dislike const char* as template argument without it being the constexpr. Since the bug is marked for eventual backports to 8u and 11u, I think we better play it safe and drop the template argument to bool, and select the message in the method body.

Additional testing:

  • build passes with GCC 6.3.0
  • build passes with GCC 9.3.0
  • jdk_jfr passes

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266206: Build failure after JDK-8264752 with older GCCs

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3759/head:pull/3759
$ git checkout pull/3759

Update a local copy of the PR:
$ git checkout pull/3759
$ git pull https://git.openjdk.java.net/jdk pull/3759/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3759

View PR using the GUI difftool:
$ git pr show -t 3759

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3759.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 28, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 28, 2021

@shipilev The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr label Apr 28, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 28, 2021

Webrevs

Copy link

@mgronlun mgronlun left a comment

Looks good, thank you.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 28, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266206: Build failure after JDK-8264752 with older GCCs

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 28, 2021
@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Apr 28, 2021

Thanks! Any other reviews? Is it trivial?
I would like to have clean nightlies tonight.

@mgronlun
Copy link

@mgronlun mgronlun commented Apr 28, 2021

Thanks! Any other reviews? Is it trivial?
I would like to have clean nightlies tonight.

It's trivial. Please go ahead.

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Apr 28, 2021

Thanks!

/integrate

@openjdk openjdk bot closed this Apr 28, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 28, 2021

@shipilev Since your change was applied there have been 6 commits pushed to the master branch:

  • c71c268: 8266165: TestNoWarningLoopStripMiningIterSet is runnable only on VM w/ G1, Shenandoah, Z and Epsilon
  • 8954bef: 8266188: mark hotspot compiler/cpuflags tests which ignore VM flags
  • 19d3c45: 8266184: a few compiler/debug tests don't check exit code
  • 7e3bc4c: 8228442: DHKeyExchange/LegacyDHEKeyExchange.java failed due to "SSLException: An established connection was aborted by the software in your host machine"
  • f40bf1d: 8266087: Move 'buffer' declaration in get_user_name_slow() inside of linux specific code
  • ec383ab: 8183374: Refactor java/lang/Runtime shell tests to java

Your commit was automatically rebased without conflicts.

Pushed as commit 21f65f8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8266206-builds-failure-old branch May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants