Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266206: Build failure after JDK-8264752 with older GCCs #3759

Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
@@ -395,8 +395,9 @@ static julong divide_with_user_unit(Argument& memory_argument, julong value) {

static const char higher_than_msg[] = "This value is higher than the maximum size limited ";
static const char lower_than_msg[] = "This value is lower than the minimum size required ";
template <typename Argument, char const *msg>
template <typename Argument, bool lower>
static void log_out_of_range_value(Argument& memory_argument, julong min_value) {
const char* msg = lower ? lower_than_msg : higher_than_msg;
if (memory_argument.value()._size != memory_argument.value()._val) {
// has multiplier
log_error(arguments) (
@@ -619,7 +620,7 @@ template <typename Argument>
static bool ensure_gteq(Argument& memory_argument, const jlong value) {
if ((jlong)memory_argument.value()._size < value) {
log_set_value(memory_argument);
log_out_of_range_value<Argument, lower_than_msg>(memory_argument, value);
log_out_of_range_value<Argument, true>(memory_argument, value);
return false;
}
return true;
@@ -654,7 +655,7 @@ template <typename Argument>
static bool ensure_lteq(Argument& memory_argument, const jlong value) {
if ((jlong)memory_argument.value()._size > value) {
log_set_value(memory_argument);
log_out_of_range_value<Argument, higher_than_msg>(memory_argument, value);
log_out_of_range_value<Argument, false>(memory_argument, value);
return false;
}
return true;