Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8197821: Test java/awt/font/TextLayout/LigatureCaretTest.java fails on Windows #3760

Closed
wants to merge 1 commit into from

Conversation

@prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Apr 28, 2021

2 tests java/awt/font/TextLayout/LigatureCaretTest.java and java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java used to fail on windows in CI testing citing "wrong text location" and " right hit failed within layout " which is due to some layout issue.
We have made harfbuzz upgrades after that and these tests are not failing neither locally nor in CI testing.

Several iterations of these tests in all platforms are working fine, so we can remove from problemlist.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8197821: Test java/awt/font/TextLayout/LigatureCaretTest.java fails on Windows
  • JDK-8197796: Test java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java fails on Windows

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3760/head:pull/3760
$ git checkout pull/3760

Update a local copy of the PR:
$ git checkout pull/3760
$ git pull https://git.openjdk.java.net/jdk pull/3760/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3760

View PR using the GUI difftool:
$ git pr show -t 3760

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3760.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 28, 2021

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 28, 2021

@prsadhuk To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing

@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Apr 28, 2021

/label add awt

@openjdk openjdk bot added the awt label Apr 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 28, 2021

@prsadhuk
The awt label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 28, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Apr 28, 2021

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8197821: Test java/awt/font/TextLayout/LigatureCaretTest.java fails on Windows
8197796: Test java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java  fails on Windows

Reviewed-by: azvegint, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

  • a1c942c: 8266170: -Wnonnull happens in classLoaderData.inline.hpp
  • 4a9f231: 8266173: -Wmaybe-uninitialized happens in jni_util.c
  • 9605aed: 8266251: compiler.inlining.InlineAccessors shouldn't do testing in driver VM
  • 03d4149: 8266255: compiler/eliminateAutobox/TestEliminateBoxInDebugInfo.java uses wrong package name
  • 794cefe: 8241354: ZGC still crashes in containers with NUMA due to get_mempolicy is disabled by default
  • 23180f8: 8266017: Refactor the *klass::array_klass_impl code to separate the non-exception-throwing API
  • f75dd80: 8266230: mark hotspot compiler/c2 tests which ignore VM flags
  • 9df6cc7: 8264678: Incomplete comment in build.tools.generatecharacter.GenerateCharacter
  • 73cfc26: 8266232: compiler.c1.TestRangeCheckEliminated should be run in driver mode
  • 3e1b90a: 8266157: Problem list several awt jtreg tests that fail on macOS 11
  • ... and 16 more: https://git.openjdk.java.net/jdk/compare/ca37be1ead40b3f407ae43330a1df0a1c3eb380e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 28, 2021
mrserb
mrserb approved these changes Apr 28, 2021
@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Apr 29, 2021

/issue add JDK-8197796

@openjdk
Copy link

@openjdk openjdk bot commented Apr 29, 2021

@prsadhuk
Adding additional issue to issue list: 8197796: Test java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java fails on Windows.

@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Apr 29, 2021

/integrate

@openjdk openjdk bot closed this Apr 29, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 29, 2021

@prsadhuk Since your change was applied there have been 26 commits pushed to the master branch:

  • a1c942c: 8266170: -Wnonnull happens in classLoaderData.inline.hpp
  • 4a9f231: 8266173: -Wmaybe-uninitialized happens in jni_util.c
  • 9605aed: 8266251: compiler.inlining.InlineAccessors shouldn't do testing in driver VM
  • 03d4149: 8266255: compiler/eliminateAutobox/TestEliminateBoxInDebugInfo.java uses wrong package name
  • 794cefe: 8241354: ZGC still crashes in containers with NUMA due to get_mempolicy is disabled by default
  • 23180f8: 8266017: Refactor the *klass::array_klass_impl code to separate the non-exception-throwing API
  • f75dd80: 8266230: mark hotspot compiler/c2 tests which ignore VM flags
  • 9df6cc7: 8264678: Incomplete comment in build.tools.generatecharacter.GenerateCharacter
  • 73cfc26: 8266232: compiler.c1.TestRangeCheckEliminated should be run in driver mode
  • 3e1b90a: 8266157: Problem list several awt jtreg tests that fail on macOS 11
  • ... and 16 more: https://git.openjdk.java.net/jdk/compare/ca37be1ead40b3f407ae43330a1df0a1c3eb380e...master

Your commit was automatically rebased without conflicts.

Pushed as commit 0e225ef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8197821 branch Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants