Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265918: java/io/Console/CharsetTest.java failed with "expect: spawn id exp6 not open" #3768

Closed
wants to merge 1 commit into from

Conversation

naotoj
Copy link
Member

@naotoj naotoj commented Apr 28, 2021

This new regression test was introduced with the Console::charset(), but it fails on ubuntu platforms assuming its locales/encoding incorrectly. To not make false-alarm/noise on test runs, this fix minimizes the tests not depending on the underlying OS's environment variables.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265918: java/io/Console/CharsetTest.java failed with "expect: spawn id exp6 not open"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3768/head:pull/3768
$ git checkout pull/3768

Update a local copy of the PR:
$ git checkout pull/3768
$ git pull https://git.openjdk.java.net/jdk pull/3768/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3768

View PR using the GUI difftool:
$ git pr show -t 3768

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3768.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 28, 2021

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 28, 2021

@naotoj The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Apr 28, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 28, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Apr 28, 2021

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265918: java/io/Console/CharsetTest.java failed with "expect: spawn id exp6 not open"

Reviewed-by: alanb, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 90 new commits pushed to the master branch:

  • 2780577: 8196415: Disable SHA-1 Signed JARs
  • 21f65f8: 8266206: Build failure after JDK-8264752 with older GCCs
  • c71c268: 8266165: TestNoWarningLoopStripMiningIterSet is runnable only on VM w/ G1, Shenandoah, Z and Epsilon
  • 8954bef: 8266188: mark hotspot compiler/cpuflags tests which ignore VM flags
  • 19d3c45: 8266184: a few compiler/debug tests don't check exit code
  • 7e3bc4c: 8228442: DHKeyExchange/LegacyDHEKeyExchange.java failed due to "SSLException: An established connection was aborted by the software in your host machine"
  • f40bf1d: 8266087: Move 'buffer' declaration in get_user_name_slow() inside of linux specific code
  • ec383ab: 8183374: Refactor java/lang/Runtime shell tests to java
  • 343a4a7: 8185127: Add tests to cover hashCode() method for java supported crypto key types
  • e325a75: 8264593: debug.cpp utilities should be available in product builds.
  • ... and 80 more: https://git.openjdk.java.net/jdk/compare/52f9d2297796e7157eeddb102a8896d7a7fad5d5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 28, 2021
@naotoj
Copy link
Member Author

@naotoj naotoj commented Apr 29, 2021

/integrate

@openjdk openjdk bot closed this Apr 29, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 29, 2021

@naotoj Since your change was applied there have been 118 commits pushed to the master branch:

  • 84b52db: 8265666: Enable AIX build platform to make external debug symbols
  • dd8286e: 8198616: java/awt/Focus/6378278/InputVerifierTest.java fails on mac
  • 5574922: 8266284: ProblemList java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java
  • df7f0b4: 8198317: Enhance JavacTool.getTask for flexibility
  • 115a413: 8265123: Add static factory methods to com.sun.net.httpserver.Filter
  • 39abac9: 8266176: -Wmaybe-uninitialized happens in libArrayIndexOutOfBoundsExceptionTest.c
  • 155da25: 8265005: Introduce the new client property for mac: apple.awt.windowTitleVisible
  • 91226fa: 8265940: Enable C2's optimization for Math.pow(x, 0.5) on all platforms
  • 56cde70: 8266265: mark hotspot compiler/vectorization tests which ignore VM flags
  • 4937214: 8266174: -Wmisleading-indentation happens in libmlib_image sources
  • ... and 108 more: https://git.openjdk.java.net/jdk/compare/52f9d2297796e7157eeddb102a8896d7a7fad5d5...master

Your commit was automatically rebased without conflicts.

Pushed as commit 294347b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@naotoj naotoj deleted the JDK-8265918 branch Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs integrated
3 participants