6514600: AbstractAction can throw NullPointerException when clone()d

[prsadhuk]

Please review a fix for an issue whereby it is seen that AbstractAction which has had its values clear()ed or nulled fails to clone and throws NPE.
This is because AbstractAction contains an inner class ArrayTable, whose 'table' field is lazily instantiated, and nulled on clear(), and thus can be null. The clone() method assumes it is not null.
Proposed fix is to add a check for null for "table" field in clone().

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-6514600: AbstractAction can throw NullPointerException when clone()d

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer)
• Pankaj Bansal (@pankaj-bansal - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/377/head:pull/377
$ git checkout pull/377

[bridgekeeper]

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prsadhuk The following label will be automatically applied to this pull request: swing.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

[mlbridge]

Webrevs

• 00: Full (a99ced1)

[openjdk]

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

6514600: AbstractAction can throw NullPointerException when clone()d

Reviewed-by: serb, pbansal

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

• 840aa2b: 8253424: Add support for running pre-submit testing using GitHub Actions
• 8e87d46: 8252857: AArch64: Shenandoah C1 CAS is not sequentially consistent
• c2692f8: 8225329: -XX:+PrintBiasedLockingStatistics causes crash during initia…
• e9c1782: 8252752: Clear card table for old regions during scan in G1
• 276fcee: 8252835: Revert fix for JDK-8246051
• ca1ed16: 8253639: Change os::attempt_reserve_memory_at parameter order
• fed3636: 8252219: C2: Randomize IGVN worklist for stress testing
• 625a935: 8253638: Cleanup os::reserve_memory and remove MAP_FIXED
• f014854: 8253624: gtest fails when run from make with read-only source directory
• 7817963: 8247691: [aarch64] Incorrect handling of VM exceptions in C1 deopt stub/traps
• ... and 18 more: https://git.openjdk.java.net/jdk/compare/dcde95ba0d68a3aa3f2f405c6141d645a52c28e4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[pankaj-bansal]

Looks good to me

[prsadhuk]

/integrate

[openjdk]

@prsadhuk Since your change was applied there have been 42 commits pushed to the master branch:

• b659132: 8252888: Collapse G1MMUTracker class hierarchy
• e63b90c: 8251358: Clean up Access configuration after Shenandoah barrier change
• 9c17a35: 8253748: StressIGV tests fail with release VMs
• 70b0fcc: 8253728: tests fail with "assert(fr.is_compiled_frame()) failed: Wrong frame type"
• 527b0e4: 8248984: Bump minimum boot jdk to JDK 15
• ac15d64: 8241151: Incorrect lint warning for no definition of serialVersionUID in a record
• d25b03e: 8253616: Change to GCC 10.2 for building on Linux at Oracle
• 821bd08: 8253667: ProblemList tools/jlink/JLinkReproducible{,3}Test.java on linux-aarch64
• 1ae6b53: 8252194: Add automated test for fix done in JDK-8218469
• 77a0f39: 8253540: InterpreterRuntime::monitorexit should be a JRT_LEAF function
• ... and 32 more: https://git.openjdk.java.net/jdk/compare/dcde95ba0d68a3aa3f2f405c6141d645a52c28e4...master

Your commit was automatically rebased without conflicts.

Pushed as commit 55c90a1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.