Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266232: compiler.c1.TestRangeCheckEliminated should be run in driver mode #3772

Closed
wants to merge 2 commits into from

Conversation

@iignatev
Copy link
Member

@iignatev iignatev commented Apr 28, 2021

Hi all,

could you please review this small patch that changes compiler.c1.TestRangeCheckEliminated to be run in driver mode (as the actual testing is done in the JVMs spawned by it, TestRangeCheckEliminated just verifies their output)? the patch also makes a few small code style changes.

Thanks,
-- Igor


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266232: compiler.c1.TestRangeCheckEliminated should be run in driver mode

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3772/head:pull/3772
$ git checkout pull/3772

Update a local copy of the PR:
$ git checkout pull/3772
$ git pull https://git.openjdk.java.net/jdk pull/3772/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3772

View PR using the GUI difftool:
$ git pr show -t 3772

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3772.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 28, 2021

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title 8266232 8266232: compiler.c1.TestRangeCheckEliminated should be run in driver mode Apr 28, 2021
@openjdk openjdk bot added the rfr label Apr 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 28, 2021

@iignatev The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 28, 2021

Webrevs

Loading

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Add Oracle copyright line.

What about @requires vm.flagless ?

Loading

@iignatev
Copy link
Member Author

@iignatev iignatev commented Apr 28, 2021

Add Oracle copyright line.

sure, I can do that. but I personally don't see this patch as significant enough to add Oracle's copyright.

What about @requires vm.flagless ?

I want to keep adding vm.flagless change as self-contained as possible for ease of review and ease of backporting. but yes, I'll add @requires vm.flagless to this test as well.

-- Igor

Loading

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Good.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 28, 2021

@iignatev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266232: compiler.c1.TestRangeCheckEliminated should be run in driver mode

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 3e1b90a: 8266157: Problem list several awt jtreg tests that fail on macOS 11
  • 3f9879f: 8266190: mark hotspot compiler/codecache tests which ignore VM flags
  • d12e01a: 8264472: Add a test group for running CDS tests with -XX:+VerifySharedSpaces
  • b3b2bb2: 8265773: incorrect jdeps message "jdk8internals" to describe a removed JDK internal API
  • 2780577: 8196415: Disable SHA-1 Signed JARs
  • 21f65f8: 8266206: Build failure after JDK-8264752 with older GCCs
  • c71c268: 8266165: TestNoWarningLoopStripMiningIterSet is runnable only on VM w/ G1, Shenandoah, Z and Epsilon

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Apr 28, 2021
@iignatev
Copy link
Member Author

@iignatev iignatev commented Apr 28, 2021

thanks, Vladimir.

/integrate

Loading

@openjdk openjdk bot closed this Apr 28, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 28, 2021

@iignatev Since your change was applied there have been 7 commits pushed to the master branch:

  • 3e1b90a: 8266157: Problem list several awt jtreg tests that fail on macOS 11
  • 3f9879f: 8266190: mark hotspot compiler/codecache tests which ignore VM flags
  • d12e01a: 8264472: Add a test group for running CDS tests with -XX:+VerifySharedSpaces
  • b3b2bb2: 8265773: incorrect jdeps message "jdk8internals" to describe a removed JDK internal API
  • 2780577: 8196415: Disable SHA-1 Signed JARs
  • 21f65f8: 8266206: Build failure after JDK-8264752 with older GCCs
  • c71c268: 8266165: TestNoWarningLoopStripMiningIterSet is runnable only on VM w/ G1, Shenandoah, Z and Epsilon

Your commit was automatically rebased without conflicts.

Pushed as commit 73cfc26.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@iignatev iignatev deleted the 8266232 branch Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants