-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8266172: -Wstringop-overflow happens in vmError.cpp #3789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back ysuenaga! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure whether to disable the warning via pragma, as this is a bogus warning, or whether to side-step by changing to int* as you have.
As long as we still crash "correctly" I suppose this is okay.
Thanks,
David
@YaSuenag This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 101 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Ping: Could you review this PR? I need one more reviewer to push. We still see this warning with GCC 11.1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this patch.
nit: does the C++ styleguide require C++ casts now? I don't remember seeing anything. I dislike the verbosity of these casts.
Cheers, Thomas
Thanks @tstuefe for the review!
Me too, but I found 745 entries when I grep'ed HotSpot source with |
/integrate |
@YaSuenag Since your change was applied there have been 121 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit c97f56c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Mailing list message from David Holmes on hotspot-dev: On 6/05/2021 5:17 pm, Thomas Stuefe wrote:
The hotspot style guide says nothing about casts, but internally we've Cheers, |
1 similar comment
Mailing list message from David Holmes on hotspot-dev: On 6/05/2021 5:17 pm, Thomas Stuefe wrote:
The hotspot style guide says nothing about casts, but internally we've Cheers, |
We can see following compiler warnings in vmError.cpp on GCC 11.
According to GCC documents, -Wstringop-overflow is meaningful only for functions that operate on character arrays, and also this point is correct because it is a test code for the crash on non-null address. So we can replace to use
int
.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3789/head:pull/3789
$ git checkout pull/3789
Update a local copy of the PR:
$ git checkout pull/3789
$ git pull https://git.openjdk.java.net/jdk pull/3789/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3789
View PR using the GUI difftool:
$ git pr show -t 3789
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3789.diff