Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266284: ProblemList java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java #3790

Closed
wants to merge 1 commit into from

Conversation

@prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Apr 29, 2021

It seems the newly deproblemlisted test DrawRotatedStringUsingRotatedFont.java which is paasing in windows,linux-x64 and macos-x64 is failing in newly added linux-aarch64 systems.
Problemlisting the test for now as it is font layout issue which might need some upgrade in harfbuzz library in those CI systems or maybe in product.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266284: ProblemList java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3790/head:pull/3790
$ git checkout pull/3790

Update a local copy of the PR:
$ git checkout pull/3790
$ git pull https://git.openjdk.java.net/jdk pull/3790/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3790

View PR using the GUI difftool:
$ git pr show -t 3790

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3790.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 29, 2021

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 29, 2021

@prsadhuk To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing

@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Apr 29, 2021

/label add 2d

@openjdk openjdk bot added the 2d label Apr 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 29, 2021

@prsadhuk
The 2d label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 29, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Apr 29, 2021

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266284: ProblemList java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java

Reviewed-by: jdv

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • df7f0b4: 8198317: Enhance JavacTool.getTask for flexibility
  • 115a413: 8265123: Add static factory methods to com.sun.net.httpserver.Filter
  • 39abac9: 8266176: -Wmaybe-uninitialized happens in libArrayIndexOutOfBoundsExceptionTest.c
  • 155da25: 8265005: Introduce the new client property for mac: apple.awt.windowTitleVisible
  • 91226fa: 8265940: Enable C2's optimization for Math.pow(x, 0.5) on all platforms

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 29, 2021
@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Apr 29, 2021

/integrate

@openjdk openjdk bot closed this Apr 29, 2021
@openjdk openjdk bot added integrated and removed ready labels Apr 29, 2021
@prsadhuk prsadhuk deleted the pl-test branch Apr 29, 2021
@openjdk openjdk bot removed the rfr label Apr 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 29, 2021

@prsadhuk Since your change was applied there have been 5 commits pushed to the master branch:

  • df7f0b4: 8198317: Enhance JavacTool.getTask for flexibility
  • 115a413: 8265123: Add static factory methods to com.sun.net.httpserver.Filter
  • 39abac9: 8266176: -Wmaybe-uninitialized happens in libArrayIndexOutOfBoundsExceptionTest.c
  • 155da25: 8265005: Introduce the new client property for mac: apple.awt.windowTitleVisible
  • 91226fa: 8265940: Enable C2's optimization for Math.pow(x, 0.5) on all platforms

Your commit was automatically rebased without conflicts.

Pushed as commit 5574922.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prrace
Copy link
Contributor

@prrace prrace commented Apr 29, 2021

The linux aarch 64 systems aren't newly added. They've been there for > 1 year
So why was this not seen whilst testing ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants