JDK-8249903: jdk/javadoc/doclet/testSerializedForm/TestSerializedForm.java needs to be updated after 8146022 got closed

[hns]

I don't know why this test was disabled because of JDK-8146022, in fact I wasn't able to understand what JDK-8146022 was all about as I didn't find a commit for it. However, the test runs fine when updated to the current output format, so I guess whatever bug caused it to fail has been fixed in the meantime. I also removed some vestiges of an old test framework nearby that has been commented out from time immemorial.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8249903: jdk/javadoc/doclet/testSerializedForm/TestSerializedForm.java needs to be updated after 8146022 got closed

Reviewers

• Jonathan Gibbons (@jonathan-gibbons - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3791/head:pull/3791
$ git checkout pull/3791

Update a local copy of the PR:
$ git checkout pull/3791
$ git pull https://git.openjdk.java.net/jdk pull/3791/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3791

View PR using the GUI difftool:
$ git pr show -t 3791

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3791.diff

[bridgekeeper]

👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@hns The following label will be automatically applied to this pull request:

• javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (4f70f1ea)

[jonathan-gibbons]

FWIW, the way I see the history here ... a bug was filed because of a resource issue, and this test was disabled because of the bug. Using @ignore was a precursor/alternate to using the problem list file.
Separately, refactoring and cleanup fixed the resource issue, using separate independent cleanup RFEs. So, JDK-8146022 was closed (without needing a changeset), and without removing the @ignore here.

Lines 49-51 are a reminder of life before JavadocTester.

[openjdk]

@hns This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8249903: jdk/javadoc/doclet/testSerializedForm/TestSerializedForm.java needs to be updated after 8146022 got closed

Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

• 51b2188: 8266267: Remove unnecessary jumps in Intel Math Library StubRoutines
• 2c381e0: 8262376: ReplaceCriticalClassesForSubgraphs.java fails if --with-build-jdk is used
• 5ecef01: 8266217: ZGC: Improve the -Xlog:gc+init output for NUMA
• 5d8c1cc: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider
• 46b4a14: 8266315: Problem list failing test java/awt/font/TextLayout/LigatureCaretTest.java
• 42af7da: 8265933: Move Java monitor related fields from class Thread to JavaThread
• 1afbab6: 8263998: Remove mentions of mc region in comments
• 51b2fb5: 8266299: ProblemList runtime/stringtable/StringTableCleaningTest.java on linux-aarch64 with ZGC
• 49d0458: 8266288: assert root method not found in witnessed_reabstraction_in_supers is too strong
• 01415f3: 8266250: WebSocketTest and WebSocketProxyTest call assertEquals(List<byte[]>, List<byte[]>)
• ... and 13 more: https://git.openjdk.java.net/jdk/compare/155da257fd9fc62f10cf81589d73501a3dd0808e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[hns]

/integrate

[openjdk]

@hns Since your change was applied there have been 23 commits pushed to the master branch:

• 51b2188: 8266267: Remove unnecessary jumps in Intel Math Library StubRoutines
• 2c381e0: 8262376: ReplaceCriticalClassesForSubgraphs.java fails if --with-build-jdk is used
• 5ecef01: 8266217: ZGC: Improve the -Xlog:gc+init output for NUMA
• 5d8c1cc: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider
• 46b4a14: 8266315: Problem list failing test java/awt/font/TextLayout/LigatureCaretTest.java
• 42af7da: 8265933: Move Java monitor related fields from class Thread to JavaThread
• 1afbab6: 8263998: Remove mentions of mc region in comments
• 51b2fb5: 8266299: ProblemList runtime/stringtable/StringTableCleaningTest.java on linux-aarch64 with ZGC
• 49d0458: 8266288: assert root method not found in witnessed_reabstraction_in_supers is too strong
• 01415f3: 8266250: WebSocketTest and WebSocketProxyTest call assertEquals(List<byte[]>, List<byte[]>)
• ... and 13 more: https://git.openjdk.java.net/jdk/compare/155da257fd9fc62f10cf81589d73501a3dd0808e...master

Your commit was automatically rebased without conflicts.

Pushed as commit 4d77171.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.