Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8198616: java/awt/Focus/6378278/InputVerifierTest.java fails on mac #3792

Closed
wants to merge 1 commit into from

Conversation

@prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Apr 29, 2021

This test was failing earlier in our nightly testing citing "jjava.lang.RuntimeException: t2 is not a focus owner

Updated test to
use swing components in EDT,
setAutoDelay for mouse events,
add a delay after frame is made visible,
move the frame to center of screen
and dispose of the frame finally.

Several iterations of the test pass in all platforms. Link in JBS.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8198616: java/awt/Focus/6378278/InputVerifierTest.java fails on mac

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3792/head:pull/3792
$ git checkout pull/3792

Update a local copy of the PR:
$ git checkout pull/3792
$ git pull https://git.openjdk.java.net/jdk pull/3792/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3792

View PR using the GUI difftool:
$ git pr show -t 3792

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3792.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 29, 2021

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 29, 2021

@prsadhuk The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt label Apr 29, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 29, 2021

Webrevs

@jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Apr 29, 2021

I dont see CI test run link in JBS.
Also if we see duplicate of this bug : https://bugs.openjdk.java.net/browse/JDK-8198233 . It is mentioned that if fails only when run in group : https://bugs.openjdk.java.net/browse/JDK-8198233?focusedCommentId=14157928&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14157928

Is CI test run in group to check whether it passes with fix?

@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Apr 29, 2021

I dont see CI test run link in JBS.
Also if we see duplicate of this bug : https://bugs.openjdk.java.net/browse/JDK-8198233 . It is mentioned that if fails only when run in group : https://bugs.openjdk.java.net/browse/JDK-8198233?focusedCommentId=14157928&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14157928

Is CI test run in group to check whether it passes with fix?

CI test run is in JBS you can check. The comment about failing in group was made in Feb 2018 when the CI jtreg jobs was used to run in samevm mode which is why test run in group used to fail as many tests was run in same vm but subseqeuently jtreg run was changed to othervm mode which we use now so each test run in its own vm.

Copy link
Member

@jayathirthrao jayathirthrao left a comment

Thanks for the clarification. LGTM.

@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Apr 29, 2021

You can similar samevm issue in JDK-8254976 where we deproblemlisted several tests

@openjdk
Copy link

@openjdk openjdk bot commented Apr 29, 2021

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8198616: java/awt/Focus/6378278/InputVerifierTest.java fails on mac

Reviewed-by: jdv

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 5574922: 8266284: ProblemList java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java
  • df7f0b4: 8198317: Enhance JavacTool.getTask for flexibility
  • 115a413: 8265123: Add static factory methods to com.sun.net.httpserver.Filter
  • 39abac9: 8266176: -Wmaybe-uninitialized happens in libArrayIndexOutOfBoundsExceptionTest.c
  • 155da25: 8265005: Introduce the new client property for mac: apple.awt.windowTitleVisible
  • 91226fa: 8265940: Enable C2's optimization for Math.pow(x, 0.5) on all platforms

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 29, 2021
@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Apr 29, 2021

/integrate

@openjdk openjdk bot closed this Apr 29, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 29, 2021

@prsadhuk Since your change was applied there have been 6 commits pushed to the master branch:

  • 5574922: 8266284: ProblemList java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java
  • df7f0b4: 8198317: Enhance JavacTool.getTask for flexibility
  • 115a413: 8265123: Add static factory methods to com.sun.net.httpserver.Filter
  • 39abac9: 8266176: -Wmaybe-uninitialized happens in libArrayIndexOutOfBoundsExceptionTest.c
  • 155da25: 8265005: Introduce the new client property for mac: apple.awt.windowTitleVisible
  • 91226fa: 8265940: Enable C2's optimization for Math.pow(x, 0.5) on all platforms

Your commit was automatically rebased without conflicts.

Pushed as commit dd8286e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8198616 branch Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants