-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8264299: Create implementation of native accessibility peer for ScrollPane and ScrollBar Java Accessibility roles #3794
Conversation
…lPane Java Accessibility role
👋 Welcome back pbansal! A progress list of the required criteria for merging this PR into |
@pankaj-bansal The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
src/java.desktop/macosx/native/libawt_lwawt/awt/JavaComponentAccessibility.m
Show resolved
Hide resolved
src/java.desktop/macosx/native/libawt_lwawt/awt/JavaComponentAccessibility.m
Outdated
Show resolved
Hide resolved
@pankaj-bansal This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 53 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
@pankaj-bansal Since your change was applied there have been 53 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 6c107fd. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Create implementation of native accessibility peer for ScrollPane and ScrollBar Java Accessibility roles.
There are no direct protocols for these two roles and there is no protocol in list of role based protocols defined by Apple Accessibility API, which can be used for these roles directly. So ScrollAreaAccessibility and ScrollBarAccessibility classes do not implement any of the role based protocols in this list. https://developer.apple.com/library/archive/documentation/Accessibility/Conceptual/AccessibilityMacOSX/ImplementingAccessibilityforCustomControls.html.
By looking at the current implementation of ScrollAreaAccessibility class in JavaComponentAccessibility and the complete list of properties and methods which can be used for any NSAccessibility class listed in https://developer.apple.com/documentation/appkit/nsaccessibility, custom implementation of ScrollAreaAccessibility and ScrollBarAccessibility is created.
I have tested these implementations by running ScrollPane demo in SwingSet2 and scrollPane demo here https://docs.oracle.com/javase/tutorial/uiswing/components/scrollpane.html. The Voice Over behaviour is consistent with the old implementation and user can navigate and interact with the ScrollArea children hierarchy as expected.
The old ScrollAreaAccessibility class in JavaComponentAccessibility is renamed to ScrollAreaAccessibility_Old as this was causing compiler errors and we are not deleting old implementations as of now. Please let me know if there is a better way to handle this.
Also, some constants defined in JavaComponentAccessibility.m have been moved to JavaComponentAccessibility.h to avoid duplication in ScrollAreaAccessibility.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3794/head:pull/3794
$ git checkout pull/3794
Update a local copy of the PR:
$ git checkout pull/3794
$ git pull https://git.openjdk.java.net/jdk pull/3794/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3794
View PR using the GUI difftool:
$ git pr show -t 3794
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3794.diff