Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264299: Create implementation of native accessibility peer for ScrollPane and ScrollBar Java Accessibility roles #3794

Closed
wants to merge 8 commits into from

Conversation

pankaj-bansal
Copy link

@pankaj-bansal pankaj-bansal commented Apr 29, 2021

Create implementation of native accessibility peer for ScrollPane and ScrollBar Java Accessibility roles.

There are no direct protocols for these two roles and there is no protocol in list of role based protocols defined by Apple Accessibility API, which can be used for these roles directly. So ScrollAreaAccessibility and ScrollBarAccessibility classes do not implement any of the role based protocols in this list. https://developer.apple.com/library/archive/documentation/Accessibility/Conceptual/AccessibilityMacOSX/ImplementingAccessibilityforCustomControls.html.

By looking at the current implementation of ScrollAreaAccessibility class in JavaComponentAccessibility and the complete list of properties and methods which can be used for any NSAccessibility class listed in https://developer.apple.com/documentation/appkit/nsaccessibility, custom implementation of ScrollAreaAccessibility and ScrollBarAccessibility is created.

I have tested these implementations by running ScrollPane demo in SwingSet2 and scrollPane demo here https://docs.oracle.com/javase/tutorial/uiswing/components/scrollpane.html. The Voice Over behaviour is consistent with the old implementation and user can navigate and interact with the ScrollArea children hierarchy as expected.

The old ScrollAreaAccessibility class in JavaComponentAccessibility is renamed to ScrollAreaAccessibility_Old as this was causing compiler errors and we are not deleting old implementations as of now. Please let me know if there is a better way to handle this.
Also, some constants defined in JavaComponentAccessibility.m have been moved to JavaComponentAccessibility.h to avoid duplication in ScrollAreaAccessibility.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264299: Create implementation of native accessibility peer for ScrollPane and ScrollBar Java Accessibility roles

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3794/head:pull/3794
$ git checkout pull/3794

Update a local copy of the PR:
$ git checkout pull/3794
$ git pull https://git.openjdk.java.net/jdk pull/3794/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3794

View PR using the GUI difftool:
$ git pr show -t 3794

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3794.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 29, 2021

👋 Welcome back pbansal! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 29, 2021

@pankaj-bansal The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt client-libs-dev@openjdk.org label Apr 29, 2021
@pankaj-bansal pankaj-bansal changed the title 8264299: Create implementation of native accessibility peer for ScrollPane Java Accessibility role 8264299: Create implementation of native accessibility peer for ScrollPane and ScrollBar Java Accessibility roles Apr 30, 2021
@pankaj-bansal pankaj-bansal marked this pull request as ready for review May 1, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label May 1, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 1, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented May 12, 2021

@pankaj-bansal This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264299: Create implementation of native accessibility peer for ScrollPane and ScrollBar Java Accessibility roles

Reviewed-by: kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 53 new commits pushed to the master branch:

  • 853ffdb: 8265934: Cleanup _suspend_flags and _special_runtime_exit_condition
  • f3c6cda: 8266162: Remove JPackage duplicate tests
  • a259ab4: 8258795: Update IANA Language Subtag Registry to Version 2021-05-11
  • b4371e9: 8266552: Technical corrections to java/util/random/package-info.java
  • e14b026: 8243287: Removal of Unsafe::defineAnonymousClass
  • a564f2c: 8266821: G1: Prefetch cards during merge heap roots phase
  • 127bfe4: 8266074: Vtable-based CHA implementation
  • 347d41d: 8164804: sun/security/ssl/SSLSocketImpl/CloseSocket.java makes not reliable time assumption
  • 17ceef9: 8266819: Separate the stop policies from the compile policies completely
  • a270cbe: 8267043: IntelliJ project doesn't handle generated sources correctly
  • ... and 43 more: https://git.openjdk.java.net/jdk/compare/18e9d28e8af02650ba30e4816404df48b1062162...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 12, 2021
@pankaj-bansal
Copy link
Author

@pankaj-bansal pankaj-bansal commented May 13, 2021

/integrate

@openjdk openjdk bot closed this May 13, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 13, 2021

@pankaj-bansal Since your change was applied there have been 53 commits pushed to the master branch:

  • 853ffdb: 8265934: Cleanup _suspend_flags and _special_runtime_exit_condition
  • f3c6cda: 8266162: Remove JPackage duplicate tests
  • a259ab4: 8258795: Update IANA Language Subtag Registry to Version 2021-05-11
  • b4371e9: 8266552: Technical corrections to java/util/random/package-info.java
  • e14b026: 8243287: Removal of Unsafe::defineAnonymousClass
  • a564f2c: 8266821: G1: Prefetch cards during merge heap roots phase
  • 127bfe4: 8266074: Vtable-based CHA implementation
  • 347d41d: 8164804: sun/security/ssl/SSLSocketImpl/CloseSocket.java makes not reliable time assumption
  • 17ceef9: 8266819: Separate the stop policies from the compile policies completely
  • a270cbe: 8267043: IntelliJ project doesn't handle generated sources correctly
  • ... and 43 more: https://git.openjdk.java.net/jdk/compare/18e9d28e8af02650ba30e4816404df48b1062162...master

Your commit was automatically rebased without conflicts.

Pushed as commit 6c107fd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@pankaj-bansal pankaj-bansal deleted the JDK-8264299 branch May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awt client-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants