Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252773: [TESTBUG] serviceability/jvmti/GetObjectSizeOverflow fails due to OOM conditions #38

Closed
wants to merge 1 commit into from

Conversation

@mychris
Copy link
Contributor

@mychris mychris commented Sep 7, 2020

The test case already handles out of memory conditions, but not if the whole JVM crashes because of it.

This PR has already been discussed on the mailing list: https://mail.openjdk.java.net/pipermail/serviceability-dev/2020-September/032884.html

@plummercj please review this PR again. I also need a sponsor for this change.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252773: [TESTBUG] serviceability/jvmti/GetObjectSizeOverflow fails due to OOM conditions

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/38/head:pull/38
$ git checkout pull/38

…ue to OOM conditions
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 7, 2020

👋 Welcome back cgo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 7, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 7, 2020

@mychris The following label will be automatically applied to this pull request: serviceability.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the serviceability label Sep 7, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 7, 2020

Webrevs

@plummercj
Copy link
Contributor

@plummercj plummercj commented Sep 8, 2020

The changes look good. I pulled your branch and submitted testing of the moved test on various hosts and with various GCs and they all have passed. It also passes tier1 testing.

I can't sponsor this commit at the moment since I am still trying to get up to speed with GIT. Maybe later this week. You can also try to find another sponsor.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 8, 2020

@plummercj Only the author (@mychris) is allowed to issue the reviewer command.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 8, 2020

@mychris This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8252773: [TESTBUG] serviceability/jvmti/GetObjectSizeOverflow fails due to OOM conditions

Reviewed-by: cjplummer, lmesnik
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 21 commits pushed to the master branch:

  • e20004d: 8249625: cleanup unused SkippedException in the tests under cds/appcds/dynamicArchive/methodHandles
  • 63a5a12: 8252658: G1: Do not consider G1HeapWastePercent during region selection within a gc
  • 001e51d: 8250563: Add KVHashtable::add_if_absent
  • 91a20ca: 8252695: Shenandoah: clean up Graal enabled/disabled filter in tests
  • 704f784: 8252871: fatal error: must own lock JvmtiThreadState_lock
  • bf5da0c: 8252897: Minor .jcheck/conf update
  • 7600274: 8252859: Inconsistent use of alpha in class AbsSeq
  • 4fb1980: 8252853: AArch64: gc/shenandoah/TestVerifyJCStress.java fails intermittently with C1
  • 73ba3ae: 8252500: ZGC on aarch64: Unable to allocate heap for certain Linux kernel configurations
  • 5dd1ead: 8252767: URLConnection.setRequestProperty throws IllegalAccessError
  • ... and 11 more: https://git.openjdk.java.net/jdk/compare/5f76deb2e064ca8a48fb8a638c23aad34bf27f9c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate e20004d7c170dc9f25f23c0a5dbf3a4c67db9423.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@plummercj, @lmesnik) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Sep 8, 2020
@lmesnik
lmesnik approved these changes Sep 8, 2020
@mychris
Copy link
Contributor Author

@mychris mychris commented Sep 8, 2020

Thanks for the review and the testing. Sponsoring is as simple as putting the /sponsor command after I executed the /integrate command. But it shouldn't be a big deal if this one is delayed a bit.

@mychris
Copy link
Contributor Author

@mychris mychris commented Sep 8, 2020

/integrate

@openjdk openjdk bot added the sponsor label Sep 8, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 8, 2020

@mychris
Your change (at version 6b5d48a) is now ready to be sponsored by a Committer.

@lmesnik
Copy link
Member

@lmesnik lmesnik commented Sep 8, 2020

/sponsor

@openjdk openjdk bot closed this Sep 8, 2020
@openjdk openjdk bot added integrated and removed sponsor ready rfr labels Sep 8, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 8, 2020

@lmesnik @mychris Since your change was applied there have been 21 commits pushed to the master branch:

  • e20004d: 8249625: cleanup unused SkippedException in the tests under cds/appcds/dynamicArchive/methodHandles
  • 63a5a12: 8252658: G1: Do not consider G1HeapWastePercent during region selection within a gc
  • 001e51d: 8250563: Add KVHashtable::add_if_absent
  • 91a20ca: 8252695: Shenandoah: clean up Graal enabled/disabled filter in tests
  • 704f784: 8252871: fatal error: must own lock JvmtiThreadState_lock
  • bf5da0c: 8252897: Minor .jcheck/conf update
  • 7600274: 8252859: Inconsistent use of alpha in class AbsSeq
  • 4fb1980: 8252853: AArch64: gc/shenandoah/TestVerifyJCStress.java fails intermittently with C1
  • 73ba3ae: 8252500: ZGC on aarch64: Unable to allocate heap for certain Linux kernel configurations
  • 5dd1ead: 8252767: URLConnection.setRequestProperty throws IllegalAccessError
  • ... and 11 more: https://git.openjdk.java.net/jdk/compare/5f76deb2e064ca8a48fb8a638c23aad34bf27f9c...master

Your commit was automatically rebased without conflicts.

Pushed as commit 26c7218.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mychris mychris deleted the mychris:8252773 branch Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.