8182043: Access to Windows Large Icons #380
Moving review from Mercurial. See https://mail.openjdk.java.net/pipermail/awt-dev/2020-August/016078.html for previous iteration.
The text was updated successfully, but these errors were encountered:
I still suggest to try the approach recommended here:
On 29.05.2020 14:35, Alexey Ivanov wrote:
If an approach above works then we could request the icon of the exact existed size, and if that size is unknown we could request some predefined size like 16,24. etc
Some additional comment was sent here:
I agree that using
On the other hand, I think the current approach is good enough. It provides access to larger set of icons and improves
I'd like to comment on this part from previous discussion:
I'd rather agree that no icon contains 100×100 size only. Yet it's pretty common that some sizes are not available in
Yet if the requested size differs from the above set, the icon will be scaled twice: by the OS and then by Java. In such a case, the result of scaling the original icon will likely be better than scaling an already scaled icon.
And I am still wondering why it happens. I can imagine a situation where an icon for a file is generated on the fly by the
The usage of different APIs can be the reason why drives lost their customised icons.
As for the additional comment:
It talks about tray icons. It depends on the way the icon is extracted, and to support High DPI environment, the icon must be an MRI. So I'd say the comment is not strictly relevant to the current discussion. However, this new implementation may improve the display of tray icons too if this new API is used to get the icon.
@azuev-java This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!