-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8266328: C2: Remove InlineWarmCalls #3805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8266328: C2: Remove InlineWarmCalls #3805
Conversation
|
👋 Welcome back vlivanov! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume @veresov uses different approach.
|
@iwanowww This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 78 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
Thanks for the reviews, Vladimir and Igor. /integrate |
|
@iwanowww Since your change was applied there have been 92 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit f86b70c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Remove InlineWarmCalls and all relevant code.
It was introduced long time ago and didn't get much attention since then. I don't see any value in keeping it around.
And there's incremental inlining support in C2 now.
Testing:
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3805/head:pull/3805$ git checkout pull/3805Update a local copy of the PR:
$ git checkout pull/3805$ git pull https://git.openjdk.java.net/jdk pull/3805/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3805View PR using the GUI difftool:
$ git pr show -t 3805Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3805.diff