Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266193: BasicJMapTest does not include testHistoParallel methods #3810

Closed
wants to merge 1 commit into from

Conversation

buddyliao
Copy link
Contributor

@buddyliao buddyliao commented Apr 30, 2021

The testHistoParallel* method are not included in the BasicJMapTest's main() method. They should be included.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266193: BasicJMapTest does not include testHistoParallel methods

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3810/head:pull/3810
$ git checkout pull/3810

Update a local copy of the PR:
$ git checkout pull/3810
$ git pull https://git.openjdk.java.net/jdk pull/3810/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3810

View PR using the GUI difftool:
$ git pr show -t 3810

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3810.diff

@bridgekeeper bridgekeeper bot added the oca label Apr 30, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 30, 2021

Hi @buddyliao, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user buddyliao" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 30, 2021

⚠️ @buddyliao a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master 155da257fd9fc62f10cf81589d73501a3dd0808e
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 30, 2021

@buddyliao The following labels will be automatically applied to this pull request:

  • core-libs
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability core-libs labels Apr 30, 2021
@buddyliao
Copy link
Contributor Author

@buddyliao buddyliao commented Apr 30, 2021

/cover

@openjdk
Copy link

@openjdk openjdk bot commented Apr 30, 2021

@buddyliao Unknown command cover - for a list of valid commands use /help.

@buddyliao
Copy link
Contributor Author

@buddyliao buddyliao commented Apr 30, 2021

/help

@openjdk
Copy link

@openjdk openjdk bot commented Apr 30, 2021

@buddyliao Available commands:

  • cc - add or remove an additional classification label
  • clean - Mark the backport pull request as a clean backport
  • contributor - adds or removes additional contributors for a PR
  • covered - used when employer has signed the OCA
  • csr - require a compatibility and specification request (CSR) for this pull request
  • help - shows this text
  • integrate - performs integration of the changes in the PR
  • issue - edit the list of issues that this PR solves
  • label - add or remove an additional classification label
  • open - Set the pull request state to "open"
  • reviewer - manage additional reviewers for a PR
  • reviewers - set the number of additional required reviewers for this PR
  • signed - used after signing the OCA
  • solves - edit the list of issues that this PR solves
  • sponsor - performs integration of a PR that is authored by a non-committer
  • summary - updates the summary in the commit message
  • test - used to run tests

@buddyliao
Copy link
Contributor Author

@buddyliao buddyliao commented Apr 30, 2021

/covered

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 30, 2021

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@bridgekeeper bridgekeeper bot added oca-verify and removed oca oca-verify labels Apr 30, 2021
@openjdk openjdk bot added the rfr label May 1, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 1, 2021

Webrevs

@AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented May 1, 2021

/label remove core-libs

@openjdk openjdk bot removed the core-libs label May 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 1, 2021

@AlanBateman
The core-libs label was successfully removed.

Copy link
Contributor

@sspitsyn sspitsyn left a comment

@buddyliao
The test update looks good to me.
Thanks,
Serguei

@buddyliao
Copy link
Contributor Author

@buddyliao buddyliao commented May 6, 2021

@buddyliao
The test update looks good to me.
Thanks,
Serguei

@sspitsyn Thanks, I have forced update the title to match between PR and JBS.
Would you help me to push it?

Thanks,
Buddy

@buddyliao buddyliao changed the title 8266193: BasicJMapTest should include testHistoParallel methods 8266193: BasicJMapTest does not include testHistoParallel methods May 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 6, 2021

⚠️ @buddyliao the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout master
$ git commit -c user.name='Preferred Full Name' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

@openjdk openjdk bot commented May 6, 2021

@buddyliao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266193: BasicJMapTest does not include testHistoParallel methods

Reviewed-by: sspitsyn, amenkov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 117 new commits pushed to the master branch:

  • 36e5ad6: 8263236: runtime/os/TestTracePageSizes.java fails on old kernels
  • 0ca86da: 8266002: vmTestbase/nsk/jvmti/ClassPrepare/classprep001 should skip events for unexpected classes
  • 52f1db6: 8262002: java/lang/instrument/VerifyLocalVariableTableOnRetransformTest.sh failed with "TestCaseScaffoldException: DummyClassWithLVT did not match .class file"
  • 04f7112: 8266293: Key protection using PBEWithMD5AndDES fails with "java.security.InvalidAlgorithmParameterException: Salt must be 8 bytes long"
  • a90b33a: 8266573: Make sure blackholes are tagged for all JVMCI paths
  • 2dcbedf: 8266044: Nested class summary should show kind of class or interface
  • e840597: 8266460: java.io tests fail on null stream with upgraded jtreg/TestNG
  • fcedfc8: 8266579: Update test/jdk/java/lang/ProcessHandle/PermissionTest.java & test/jdk/java/sql/testng/util/TestPolicy.java
  • c665dba: 8266561: Remove Compile::_save_argument_registers
  • 47d4438: 8266426: ZHeapIteratorOopClosure does not handle native access properly
  • ... and 107 more: https://git.openjdk.java.net/jdk/compare/155da257fd9fc62f10cf81589d73501a3dd0808e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@sspitsyn, @alexmenkov) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label May 6, 2021
@buddyliao
Copy link
Contributor Author

@buddyliao buddyliao commented May 6, 2021

/integrate

@openjdk openjdk bot added the sponsor label May 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 6, 2021

@buddyliao
Your change (at version d5edd15) is now ready to be sponsored by a Committer.

@sspitsyn
Copy link
Contributor

@sspitsyn sspitsyn commented May 6, 2021

@buddyliao
Two reviews are required for serviceability fixes.
I'll sponsor it once you get another review.

@sspitsyn
Copy link
Contributor

@sspitsyn sspitsyn commented May 7, 2021

/sponsor

@openjdk openjdk bot closed this May 7, 2021
@openjdk openjdk bot added integrated and removed sponsor ready rfr labels May 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 7, 2021

@sspitsyn @buddyliao Since your change was applied there have been 117 commits pushed to the master branch:

  • 36e5ad6: 8263236: runtime/os/TestTracePageSizes.java fails on old kernels
  • 0ca86da: 8266002: vmTestbase/nsk/jvmti/ClassPrepare/classprep001 should skip events for unexpected classes
  • 52f1db6: 8262002: java/lang/instrument/VerifyLocalVariableTableOnRetransformTest.sh failed with "TestCaseScaffoldException: DummyClassWithLVT did not match .class file"
  • 04f7112: 8266293: Key protection using PBEWithMD5AndDES fails with "java.security.InvalidAlgorithmParameterException: Salt must be 8 bytes long"
  • a90b33a: 8266573: Make sure blackholes are tagged for all JVMCI paths
  • 2dcbedf: 8266044: Nested class summary should show kind of class or interface
  • e840597: 8266460: java.io tests fail on null stream with upgraded jtreg/TestNG
  • fcedfc8: 8266579: Update test/jdk/java/lang/ProcessHandle/PermissionTest.java & test/jdk/java/sql/testng/util/TestPolicy.java
  • c665dba: 8266561: Remove Compile::_save_argument_registers
  • 47d4438: 8266426: ZHeapIteratorOopClosure does not handle native access properly
  • ... and 107 more: https://git.openjdk.java.net/jdk/compare/155da257fd9fc62f10cf81589d73501a3dd0808e...master

Your commit was automatically rebased without conflicts.

Pushed as commit 66191ff.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated serviceability
4 participants