Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266389: ProblemList java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java on generic-all #3824

Closed
wants to merge 2 commits into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Apr 30, 2021

A trivial fix to ProblemList java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java on linux-x64.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266389: ProblemList java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java on generic-all

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3824/head:pull/3824
$ git checkout pull/3824

Update a local copy of the PR:
$ git checkout pull/3824
$ git pull https://git.openjdk.java.net/jdk pull/3824/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3824

View PR using the GUI difftool:
$ git pr show -t 3824

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3824.diff

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add 2d

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review April 30, 2021 19:33
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 30, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review hotspot-runtime hotspot-runtime-dev@openjdk.org labels Apr 30, 2021
@openjdk
Copy link

openjdk bot commented Apr 30, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the 2d client-libs-dev@openjdk.org label Apr 30, 2021
@openjdk
Copy link

openjdk bot commented Apr 30, 2021

@dcubed-ojdk
The 2d label was successfully added.

@openjdk
Copy link

openjdk bot commented Apr 30, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266389: ProblemList java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java on generic-all

Reviewed-by: mikael, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • dd05158: 8266155: Convert java.base to use Stream.toList()
  • c36c63a: 8260560: convert jdeps and jdeprscan tools to use Stream.toList()

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 30, 2021
@prrace
Copy link
Contributor

prrace commented Apr 30, 2021

Please make it generic

@mlbridge
Copy link

mlbridge bot commented Apr 30, 2021

Webrevs

@@ -526,8 +526,7 @@ java/awt/security/WarningWindowDisposeTest/WarningWindowDisposeTest.java 8266059
java/awt/Robot/Delay/InterruptOfDelay.java 8265986 macosx-all
java/awt/MenuBar/TestNoScreenMenuBar.java 8265987 macosx-all

#linux-aarch64 failure
java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java 8266283 linux-aarch64
java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java 8266283 linux-all
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generic like it used to be please

@dcubed-ojdk
Copy link
Member Author

Will do.

@dcubed-ojdk dcubed-ojdk changed the title 8266389: ProblemList java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java on linux-x64 8266389: ProblemList java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java on generic-all Apr 30, 2021
@dcubed-ojdk
Copy link
Member Author

@vidmik and @prrace - Thanks for the reviews!

/integrate

@openjdk openjdk bot closed this Apr 30, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 30, 2021
@openjdk
Copy link

openjdk bot commented Apr 30, 2021

@dcubed-ojdk Since your change was applied there have been 2 commits pushed to the master branch:

  • dd05158: 8266155: Convert java.base to use Stream.toList()
  • c36c63a: 8260560: convert jdeps and jdeprscan tools to use Stream.toList()

Your commit was automatically rebased without conflicts.

Pushed as commit 50fa162.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8266389 branch April 30, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2d client-libs-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants