Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266412: Remove redundant TemplateInterpreter entries #3833

Closed
wants to merge 1 commit into from

Conversation

cl4es
Copy link
Member

@cl4es cl4es commented May 2, 2021

This patch trivially removes two redundant entry point generation calls that I accidentally forgot to remove after a refactoring in https://bugs.openjdk.java.net/browse/JDK-8255271

A very slim improvement (~70k fewer instructions executed on bootstrap), but still..


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266412: Remove redundant TemplateInterpreter entries

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3833/head:pull/3833
$ git checkout pull/3833

Update a local copy of the PR:
$ git checkout pull/3833
$ git pull https://git.openjdk.java.net/jdk pull/3833/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3833

View PR using the GUI difftool:
$ git pr show -t 3833

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3833.diff

@cl4es
Copy link
Member Author

@cl4es cl4es commented May 2, 2021

/label remove hotspot
/label add hotspot-runtime

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 2, 2021

👋 Welcome back redestad! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 2, 2021

@cl4es The hotspot label was not set.

@openjdk openjdk bot added the hotspot-runtime label May 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 2, 2021

@cl4es
The hotspot-runtime label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 2, 2021

Webrevs

Copy link
Member

@DamonFool DamonFool left a comment

Looks good to me.
Thanks.

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Looks good.

Thanks,
David

@openjdk
Copy link

@openjdk openjdk bot commented May 3, 2021

@cl4es This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266412: Remove redundant TemplateInterpreter entries

Reviewed-by: jiefu, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 111 new commits pushed to the master branch:

  • 7e30130: 8266401: mark hotspot compiler/intrinsics/sha/cli tests which ignore VM flags
  • dedddd5: 8266248: Compilation failure in PLATFORM_API_MacOSX_MidiUtils.c with Xcode 12.5
  • 5c083e8: 8266129: tools/jpackage/windows/WinInstallerIconTest.java hangs with fastdebug
  • 3e667cc: 8265356: need code example for getting canonical constructor of a Record
  • f86b70c: 8266328: C2: Remove InlineWarmCalls
  • 928d632: 8252237: C2: Call to compute_separating_interferences has wrong argument order
  • 50fa162: 8266389: ProblemList java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java on generic-all
  • dd05158: 8266155: Convert java.base to use Stream.toList()
  • c36c63a: 8260560: convert jdeps and jdeprscan tools to use Stream.toList()
  • 096e9e5: 8266318: Switch to macos prefix for macOS bundles
  • ... and 101 more: https://git.openjdk.java.net/jdk/compare/0a4c33826d0422af7c4cfa5f479fe0b6b0f83d23...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 3, 2021
@cl4es
Copy link
Member Author

@cl4es cl4es commented May 3, 2021

@DamonFool @dholmes-ora: thanks for reviewing!

/integrate

@openjdk openjdk bot closed this May 3, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 3, 2021

@cl4es Since your change was applied there have been 113 commits pushed to the master branch:

  • c5dc657: 8266056: runtime/stringtable/StringTableCleaningTest.java failed with "RuntimeException: Missing Callback in [10, 11]"
  • 8fa50eb: 8263363: Minor cleanup of Lanai code - unused code removal and comments correction
  • 7e30130: 8266401: mark hotspot compiler/intrinsics/sha/cli tests which ignore VM flags
  • dedddd5: 8266248: Compilation failure in PLATFORM_API_MacOSX_MidiUtils.c with Xcode 12.5
  • 5c083e8: 8266129: tools/jpackage/windows/WinInstallerIconTest.java hangs with fastdebug
  • 3e667cc: 8265356: need code example for getting canonical constructor of a Record
  • f86b70c: 8266328: C2: Remove InlineWarmCalls
  • 928d632: 8252237: C2: Call to compute_separating_interferences has wrong argument order
  • 50fa162: 8266389: ProblemList java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java on generic-all
  • dd05158: 8266155: Convert java.base to use Stream.toList()
  • ... and 103 more: https://git.openjdk.java.net/jdk/compare/0a4c33826d0422af7c4cfa5f479fe0b6b0f83d23...master

Your commit was automatically rebased without conflicts.

Pushed as commit 05cfac9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@cl4es cl4es deleted the itos_leftovers branch May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime integrated
3 participants