Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266436: Synthetic constructor trees have non-null return type #3842

Closed
wants to merge 1 commit into from

Conversation

@lahodaj
Copy link
Contributor

@lahodaj lahodaj commented May 3, 2021

When javac generates the AST for default (synthetic) constructor, it will create a return type void for them, while for ordinary constructors, it uses null as the return type. This change proposes to consistently use null as the return type of constructors. (Eventually, we might want to avoid generating the synthetic constructor tree.)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266436: Synthetic constructor trees have non-null return type

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3842/head:pull/3842
$ git checkout pull/3842

Update a local copy of the PR:
$ git checkout pull/3842
$ git pull https://git.openjdk.java.net/jdk pull/3842/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3842

View PR using the GUI difftool:
$ git pr show -t 3842

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3842.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 3, 2021

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label May 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 3, 2021

@lahodaj The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the compiler label May 3, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 3, 2021

Webrevs

Loading

Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle left a comment

looks good

Loading

@openjdk
Copy link

@openjdk openjdk bot commented May 3, 2021

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266436: Synthetic constructor trees have non-null return type

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 45760d4: 8266320: (bf) ReadOnlyBufferException in heap buffer put(String,int,int) should not be conditional
  • ff65920: 8265491: Math Signum optimization for x86
  • 55cc0af: 8266185: Shenandoah: Fix incorrect comment/assertion messages
  • 880c138: 8265349: vmTestbase/../stress/compiler/deoptimize/Test.java fails with OOME due to CodeCache exhaustion.
  • 001c514: 8265322: C2: Simplify control inputs for BarrierSetC2::obj_allocate
  • 194bcec: 8265984: Concurrent GC: Some tests fail "assert(is_frame_safe(f)) failed: Frame must be safe"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label May 3, 2021
@lahodaj
Copy link
Contributor Author

@lahodaj lahodaj commented May 5, 2021

/integrate

Loading

@openjdk openjdk bot closed this May 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 5, 2021

@lahodaj Since your change was applied there have been 33 commits pushed to the master branch:

  • c9873c4: 8260621: (jrtfs) ThreadLocal memory leak in ImageBufferCache when using jrtfs
  • 82768d9: 8221503: vmTestbase/nsk/jdb/eval/eval001/eval001.java fails with: com.sun.jdi.InvalidTypeException: Can't assign double[][][] to double[][][]
  • b71f85a: 8264398: BevelBorderUIResource​(int, Color, Color) and BevelBoder(int, Color, Color) spec should clarify about usage of highlight and shadow color
  • b172555: 8266171: -Warray-bounds happens in imageioJPEG.c
  • 8bcebe7: 8265505: findsym does not work on remote debug server
  • b88785d: 8266038: Move newAddress() to JVMDebugger
  • 2c53654: 8266179: [macos] jpackage should specify architecture for produced pkg files
  • d282799: 8255566: Add size validation when parsing values from VersionProps
  • 61365d5: 8266465: Add wildcard to JTwork/JTreport exclude in jib-profiles.js
  • f00b70e: 8266527: RandomTestCoverage.java failing due to API removal
  • ... and 23 more: https://git.openjdk.java.net/jdk/compare/1d9ea3ae0ff6e5283781c8e088578c2e8df63aaa...master

Your commit was automatically rebased without conflicts.

Pushed as commit a8046c9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants