8264777: Overload optimized FileInputStream::readAllBytes #3845
@bplb This change now passes all automated pre-integration checks.
After integration, the commit message for the final commit will be:
At the time when this comment was updated there had been 220 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
I think you've addressed the obvious bugs now but I'm still nervous that the lseek will fail for some special devices (time will tell).
It would be good to do some cleanup on the test before you integrate this. If you change it to use try-with-resources will it will avoid leaving the file open when the test fails. Also would be good to add a test for readNBytes(0) for the empty-file case. There's a typo in one of the exception messages ("expecte").
@bplb Since your change was applied there have been 221 commits pushed to the
Your commit was automatically rebased without conflicts.
Pushed as commit da4dfde.