Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266465: Add wildcard to JTwork/JTreport exclude in jib-profiles.js #3847

Closed
wants to merge 1 commit into from

Conversation

@dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented May 3, 2021

If you stash away jtreg test results in a specific JTwork directory this can causes problem creating a jib source bundle. Simple fix is to add a wildcard to the JTwork and JTreport exclude entries.

Thanks,
David


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266465: Add wildcard to JTwork/JTreport exclude in jib-profiles.js

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3847/head:pull/3847
$ git checkout pull/3847

Update a local copy of the PR:
$ git checkout pull/3847
$ git pull https://git.openjdk.java.net/jdk pull/3847/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3847

View PR using the GUI difftool:
$ git pr show -t 3847

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3847.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 3, 2021

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label May 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 3, 2021

@dholmes-ora The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the build label May 3, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 3, 2021

Webrevs

Loading

erikj79
erikj79 approved these changes May 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 4, 2021

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266465: Add wildcard to JTwork/JTreport exclude in jib-profiles.js

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 05e6017: 8265137: java.util.Random suddenly has new public methods nowhere documented
  • aa90df6: 8266187: Memory leak in appendBootClassPath()
  • b651904: 8266438: Compile::remove_useless_nodes does not remove opaque nodes
  • 141cc2f: 8261527: Record page size used for underlying mapping in ReservedSpace
  • 8e071c4: 8265784: [C2] Hoisting of DecodeN leaves MachTemp inputs behind
  • ce1bc9d: 8266432: ZGC: GC allocation stalls can trigger deadlocks
  • 30ccd80: 8264950: Set opaque for JTooltip in config file of NimbusLookAndFeel
  • cfdf4a7: 8266449: cleanup jtreg tags in compiler/intrinsics/sha/cli tests

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label May 4, 2021
@dholmes-ora
Copy link
Member Author

@dholmes-ora dholmes-ora commented May 4, 2021

/integrate

Loading

@openjdk openjdk bot closed this May 4, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 4, 2021

@dholmes-ora Since your change was applied there have been 16 commits pushed to the master branch:

  • f00b70e: 8266527: RandomTestCoverage.java failing due to API removal
  • c53dee7: 8266227: Fix help text for --mac-signing-keychain
  • 80323b7: 8261169: Upgrade HarfBuzz to the latest 2.8.0
  • 9c4efdd: 8263124: Missed initialization of baselineY in sun.font.StrikeMetrics
  • 4e96b31: 8265989: System property for the native character encoding name
  • 8b37d48: 8255493: Support for pre-generated java.lang.invoke classes in CDS dynamic archive
  • 770dfc1: 8265279: Remove unused RandomGeneratorFactory.all(Class category)
  • ee5bba0: 8265767: compiler/eliminateAutobox/TestIntBoxing.java crashes on arm32 after 8264649 in debug VMs
  • 05e6017: 8265137: java.util.Random suddenly has new public methods nowhere documented
  • aa90df6: 8266187: Memory leak in appendBootClassPath()
  • ... and 6 more: https://git.openjdk.java.net/jdk/compare/3544a9d0e4a071ad9c82aa17ab113e0101b4020b...master

Your commit was automatically rebased without conflicts.

Pushed as commit 61365d5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@dholmes-ora dholmes-ora deleted the 8266465 branch May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants