-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8226384: Implement a better logic to switch between OpenGL and Metal pipeline #3851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back jdv! A progress list of the required criteria for merging this PR into |
@jayathirthrao The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
jtreg/JCK all test run is green in both OpenGL and Metal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Is there anything not covered by this fix ?
@jayathirthrao This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 72 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Hi Phil, We still have some if else checks in initialization paths like CPlatformView.initialize(), CPlatformEmbeddedFrame.initialize() and static access of RenderQueue method, like in LWCToolkit.sync(). Thanks, |
@mrserb Please share your inputs. |
/integrate |
@jayathirthrao Since your change was applied there have been 102 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 53db2a0. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
We have many if else conditions to select OpenGL/Metal pipeline objects.
Apart from initialization phase we should not fetch these objects everytime checking whether we are using OpenGL/Metal pipeline.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3851/head:pull/3851
$ git checkout pull/3851
Update a local copy of the PR:
$ git checkout pull/3851
$ git pull https://git.openjdk.java.net/jdk pull/3851/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3851
View PR using the GUI difftool:
$ git pr show -t 3851
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3851.diff