Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8226384: Implement a better logic to switch between OpenGL and Metal pipeline #3851

Closed
wants to merge 2 commits into from

Conversation

jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented May 4, 2021

We have many if else conditions to select OpenGL/Metal pipeline objects.
Apart from initialization phase we should not fetch these objects everytime checking whether we are using OpenGL/Metal pipeline.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8226384: Implement a better logic to switch between OpenGL and Metal pipeline

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3851/head:pull/3851
$ git checkout pull/3851

Update a local copy of the PR:
$ git checkout pull/3851
$ git pull https://git.openjdk.java.net/jdk pull/3851/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3851

View PR using the GUI difftool:
$ git pr show -t 3851

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3851.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 4, 2021

👋 Welcome back jdv! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 4, 2021
@openjdk
Copy link

openjdk bot commented May 4, 2021

@jayathirthrao The following labels will be automatically applied to this pull request:

  • 2d
  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added 2d client-libs-dev@openjdk.org awt client-libs-dev@openjdk.org labels May 4, 2021
@mlbridge
Copy link

mlbridge bot commented May 4, 2021

Webrevs

@jayathirthrao
Copy link
Member Author

jayathirthrao commented May 4, 2021

jtreg/JCK all test run is green in both OpenGL and Metal.
Also sanity check using J2DDemo and SwingSet2 is fine.

prrace
prrace approved these changes May 4, 2021
Copy link
Contributor

@prrace prrace left a comment

LGTM. Is there anything not covered by this fix ?

@openjdk
Copy link

openjdk bot commented May 4, 2021

@jayathirthrao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8226384: Implement a better logic to switch between OpenGL and Metal pipeline

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 72 new commits pushed to the master branch:

  • 0ca86da: 8266002: vmTestbase/nsk/jvmti/ClassPrepare/classprep001 should skip events for unexpected classes
  • 52f1db6: 8262002: java/lang/instrument/VerifyLocalVariableTableOnRetransformTest.sh failed with "TestCaseScaffoldException: DummyClassWithLVT did not match .class file"
  • 04f7112: 8266293: Key protection using PBEWithMD5AndDES fails with "java.security.InvalidAlgorithmParameterException: Salt must be 8 bytes long"
  • a90b33a: 8266573: Make sure blackholes are tagged for all JVMCI paths
  • 2dcbedf: 8266044: Nested class summary should show kind of class or interface
  • e840597: 8266460: java.io tests fail on null stream with upgraded jtreg/TestNG
  • fcedfc8: 8266579: Update test/jdk/java/lang/ProcessHandle/PermissionTest.java & test/jdk/java/sql/testng/util/TestPolicy.java
  • c665dba: 8266561: Remove Compile::_save_argument_registers
  • 47d4438: 8266426: ZHeapIteratorOopClosure does not handle native access properly
  • 2438498: 8252758: Lanai: Optimize index calculation while copying glyphs
  • ... and 62 more: https://git.openjdk.java.net/jdk/compare/c5dc657f0be90bd594663dcc612f40a930c2bbe7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 4, 2021
@jayathirthrao
Copy link
Member Author

jayathirthrao commented May 5, 2021

LGTM. Is there anything not covered by this fix ?

Hi Phil,

We still have some if else checks in initialization paths like CPlatformView.initialize(), CPlatformEmbeddedFrame.initialize() and static access of RenderQueue method, like in LWCToolkit.sync().

Thanks,
Jay

prrace
prrace approved these changes May 6, 2021
@jayathirthrao
Copy link
Member Author

jayathirthrao commented May 7, 2021

@mrserb Please share your inputs.

@jayathirthrao
Copy link
Member Author

jayathirthrao commented May 10, 2021

/integrate

@openjdk openjdk bot closed this May 10, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 10, 2021
@openjdk
Copy link

openjdk bot commented May 10, 2021

@jayathirthrao Since your change was applied there have been 102 commits pushed to the master branch:

  • 1603ca2: 8241248: NullPointerException in sun.security.ssl.HKDF.extract(HKDF.java:93)
  • 0f925d1: 8266015: Implement AdapterHandlerLibrary lookup fast-path for common adapters
  • 69b96f9: 8266610: Method RandomAccessFile#length() returns 0 for block devices on linux.
  • 9b76955: 8266249: javax/swing/JPopupMenu/7156657/bug7156657.java fails on macOS
  • 3af4efd: 8265291: Error in Javadoc for doAccessibleAction API in AccessibleJSlider class
  • be4f25b: 8266369: (se) Add wepoll based Selector
  • ff77ca8: 8266675: Optimize IntHashTable for encapsulation and ease of use
  • 04fad70: 8266765: [BACKOUT] JDK-8255493 Support for pre-generated java.lang.invoke classes in CDS dynamic archive
  • 0790e60: 8196743: jstatd doesn't see new Java processes inside Docker container
  • c6aa8f1: 8232644: bugs in serialized-form.html
  • ... and 92 more: https://git.openjdk.java.net/jdk/compare/c5dc657f0be90bd594663dcc612f40a930c2bbe7...master

Your commit was automatically rebased without conflicts.

Pushed as commit 53db2a0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jayathirthrao jayathirthrao deleted the JDK-8226384 branch May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2d client-libs-dev@openjdk.org awt client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants