Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266499: Delete dead code in aarch64.ad #3860

Closed
wants to merge 1 commit into from

Conversation

@theRealAph
Copy link
Contributor

@theRealAph theRealAph commented May 4, 2021

Just dead code, nothing to see here.

I had to change a few MacroAssembler to C2_MacroAssembler in
ad_encode.m4, which seems not to have been updated when 8241436 was
committed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3860/head:pull/3860
$ git checkout pull/3860

Update a local copy of the PR:
$ git checkout pull/3860
$ git pull https://git.openjdk.java.net/jdk pull/3860/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3860

View PR using the GUI difftool:
$ git pr show -t 3860

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3860.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 4, 2021

👋 Welcome back aph! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label May 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 4, 2021

@theRealAph The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 4, 2021

Webrevs

Loading

@openjdk
Copy link

@openjdk openjdk bot commented May 4, 2021

@theRealAph This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266499: Delete dead code in aarch64.ad

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label May 4, 2021
@theRealAph
Copy link
Contributor Author

@theRealAph theRealAph commented May 5, 2021

/integrate

Loading

@openjdk openjdk bot closed this May 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 5, 2021

@theRealAph Since your change was applied there have been 21 commits pushed to the master branch:

  • 71d0858: 8266522: Shenandoah: Shenandoah LRB calls wrong runtime barrier on aarch64
  • 0ac84d1: 8266506: [aix] Treat mapping attempt too close to BRK as a mapping error
  • 02cdd6e: 8266419: [aix] in mmap mode, os::attempt_reserve_memory_at() fails to handle wrong mapping address
  • 250b45a: 8266222: [aix] In mmap-mode, partial releases with os::release_memory may trash internal bookkeeping
  • 65ce4d2: 8266491: Remove resolve and obj_equals leftovers from BarrierSetAssembler
  • a8046c9: 8266436: Synthetic constructor trees have non-null return type
  • c9873c4: 8260621: (jrtfs) ThreadLocal memory leak in ImageBufferCache when using jrtfs
  • 82768d9: 8221503: vmTestbase/nsk/jdb/eval/eval001/eval001.java fails with: com.sun.jdi.InvalidTypeException: Can't assign double[][][] to double[][][]
  • b71f85a: 8264398: BevelBorderUIResource​(int, Color, Color) and BevelBoder(int, Color, Color) spec should clarify about usage of highlight and shadow color
  • b172555: 8266171: -Warray-bounds happens in imageioJPEG.c
  • ... and 11 more: https://git.openjdk.java.net/jdk/compare/770dfc1ec4fe28bc73612c8b0dd8423dd49e1597...master

Your commit was automatically rebased without conflicts.

Pushed as commit ef0f693.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants