-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8266498: Make debug ps() call print_stack #3861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me.
@coleenp This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Lois
Thanks Lois and Thomas. |
/integrate |
@coleenp Since your change was applied there have been 24 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 6ba911d. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Fix ps() call print_stack. Tested manually and with fastdebug and debug. Also removed hsfind() because find() is the same thing and nobody's using dbx anymore (and the overload that made me add it might be long gone).
Tested with tier1 sanity.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3861/head:pull/3861
$ git checkout pull/3861
Update a local copy of the PR:
$ git checkout pull/3861
$ git pull https://git.openjdk.java.net/jdk pull/3861/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3861
View PR using the GUI difftool:
$ git pr show -t 3861
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3861.diff