8266519: Cleanup resolve() leftovers from BarrierSet et al

[rkennke]

Shenandoah used to require a way to resolve oops, but it's long unused the the corresponding code in the access machinery is obsolete. Let's remove it.

Testing:

• hotspot_gc_shenandoah
• tier1
• tier2

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8266519: Cleanup resolve() leftovers from BarrierSet et al

Reviewers

• Kim Barrett (@kimbarrett - Reviewer)
• Stefan Karlsson (@stefank - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3862/head:pull/3862
$ git checkout pull/3862

Update a local copy of the PR:
$ git checkout pull/3862
$ git pull https://git.openjdk.java.net/jdk pull/3862/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3862

View PR using the GUI difftool:
$ git pr show -t 3862

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3862.diff

[bridgekeeper]

👋 Welcome back rkennke! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rkennke The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[rkennke]

/cc hotspot-gc

[openjdk]

@rkennke
The hotspot-gc label was successfully added.

[mlbridge]

Webrevs

• 00: Full (3c311863)

[bridgekeeper]

@rkennke This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@rkennke This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[rkennke]

/open

[openjdk]

@rkennke @HostUserDetails{id=1066269, username='rkennke', fullName='null'} this pull request is now open

[rkennke]

Ping? Any takers?

[kimbarrett]

Ping? Any takers?

The only email for this PR I have any record of is the auto-withdraw at the end of June. Weird! I'll have a look.

[kimbarrett]

Looks good.

[openjdk]

@rkennke This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266519: Cleanup resolve() leftovers from BarrierSet et al

Reviewed-by: kbarrett, stefank

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1444 new commits pushed to the master branch:

• 6d3d479: 8272667: substandard error messages from the docs build
• 73da66f: 8272318: Improve performance of HeapDumpAllTest
• 96107e3: 8272573: Redundant unique_concrete_method_4 dependencies
• 4d6593c: 8272124: Cgroup v1 initialization causes NullPointerException when cgroup path contains colon
• 30b0f82: 8272626: Avoid C-style array declarations in java.*
• e8f1219: 8271276: C2: Wrong JVM state used for receiver null check
• 79a06df: 8272567: [IR Framework] Make AbstractInfo.getRandom() static
• 481c1f0: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked
• 5189047: 8272558: IR Test Framework README misses some flags
• ec63957: 8272398: Update DockerTestUtils.buildJdkDockerImage()
• ... and 1434 more: https://git.openjdk.java.net/jdk/compare/b65190483c824234b86e2e43cf85009d926713bf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kimbarrett]

The initial RFR email made it into the hotspot-dev mail.openjdk.java.net archive. But it doesn't look like it made it to me for some reason. Was there some kind of email outage around that time?

[rkennke]

/integrate

[openjdk]

Going to push as commit 7eccbd4.
Since your change was applied there have been 1450 commits pushed to the master branch:

• 9569159: 8272674: Logging missing keytab file in Krb5LoginModule
• 51c1b9a: 8272616: Strange code in java.text.DecimalFormat#applyPattern
• 03b5e99: 8272165: Consolidate mark_must_be_preserved() variants
• ab41812: 8272576: G1: Use more accurate integer type for collection set length
• 82b2f21: 8272579: G1: remove unnecesary null check for G1ParScanThreadStateSet::_states slots
• 1c80f07: 8272334: com.sun.net.httpserver.HttpExchange: Improve API doc of getRequestHeaders
• 6d3d479: 8272667: substandard error messages from the docs build
• 73da66f: 8272318: Improve performance of HeapDumpAllTest
• 96107e3: 8272573: Redundant unique_concrete_method_4 dependencies
• 4d6593c: 8272124: Cgroup v1 initialization causes NullPointerException when cgroup path contains colon
• ... and 1440 more: https://git.openjdk.java.net/jdk/compare/b65190483c824234b86e2e43cf85009d926713bf...master

Your commit was automatically rebased without conflicts.

[openjdk]

@rkennke Pushed as commit 7eccbd4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.