Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8266527 RandomTestCoverage.java failing due to API removal #3867

Closed
wants to merge 1 commit into from

Conversation

JimLaskey
Copy link
Member

@JimLaskey JimLaskey commented May 4, 2021

RandomTestCoverage.java was overlooked when doing local test. Apologies.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266527: RandomTestCoverage.java failing due to API removal

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3867/head:pull/3867
$ git checkout pull/3867

Update a local copy of the PR:
$ git checkout pull/3867
$ git pull https://git.openjdk.java.net/jdk pull/3867/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3867

View PR using the GUI difftool:
$ git pr show -t 3867

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3867.diff

@JimLaskey
Copy link
Member Author

/label core-libs

@JimLaskey
Copy link
Member Author

/rfr

@bridgekeeper
Copy link

bridgekeeper bot commented May 4, 2021

👋 Welcome back jlaskey! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review core-libs core-libs-dev@openjdk.org labels May 4, 2021
@openjdk
Copy link

openjdk bot commented May 4, 2021

@JimLaskey
The core-libs label was successfully added.

@openjdk
Copy link

openjdk bot commented May 4, 2021

@JimLaskey Unknown command rfr - for a list of valid commands use /help.

@mlbridge
Copy link

mlbridge bot commented May 4, 2021

Webrevs

Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to clean those out.

@JimLaskey
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented May 4, 2021

@JimLaskey This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266527: RandomTestCoverage.java failing due to API removal

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 4, 2021
@openjdk openjdk bot closed this May 4, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 4, 2021
@openjdk
Copy link

openjdk bot commented May 4, 2021

@JimLaskey Pushed as commit f00b70e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants