8266531: ZAddress::address() should be removed from SA

[YaSuenag]

ZAddress::address() has been removed since JDK-8235748, however SA has not followed it. Thus some SA tests would fail with ZGC.
After this change, more than half of jtreg tests which are listed in ProblemList-zgc.txt pass on Linux x64 with -vmoption:-XX:+UseZGC. Please see the change of ProblemList-zgc.txt what test can be resolved.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8266531: ZAddress::address() should be removed from SA

Reviewers

• Chris Plummer (@plummercj - Reviewer)
• Stefan Karlsson (@stefank - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3868/head:pull/3868
$ git checkout pull/3868

Update a local copy of the PR:
$ git checkout pull/3868
$ git pull https://git.openjdk.java.net/jdk pull/3868/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3868

View PR using the GUI difftool:
$ git pr show -t 3868

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3868.diff

[bridgekeeper]

👋 Welcome back ysuenaga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@YaSuenag The following labels will be automatically applied to this pull request:

• hotspot-gc
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (04a5cd5f)

[plummercj]

The changes look good. I think it would be best if the 2nd review came from the GC team.

[openjdk]

@YaSuenag This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266531: ZAddress::address() should be removed from SA

Reviewed-by: cjplummer, stefank

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 84 new commits pushed to the master branch:

• 18e9d28: 8266676: G1: Remove dead code init_node_id_to_index_map()
• 0e7bdae: 8265062: Remove duplication constant MaxTextureSize
• 10a049e: 8265956: JVM crashes when matching LShiftVB Node
• 9713152: 8262092: vmTestbase/nsk/jvmti/scenarios/hotswap/HS102/hs102t001/TestDescription.java SIGSEGV in memmove_ssse3
• 23446f1: 8265128: [REDO] Optimize Vector API slice and unslice operations
• e5d3ee3: 8266802: Shenandoah: Round up region size to page size unconditionally
• 8851cb6: 8266779: Use instead of ZERO_WIDTH_SPACE
• 0cc7833: 8265208: [JEP-356] : SplittableRandom and SplittableGenerators - splits() methods does not throw NullPointerException when source is null
• f78440a: 8266440: Shenandoah: TestReferenceShortcutCycle.java test failed on AArch64
• de78431: 8241502: C2: Migrate x86_64.ad to MacroAssembler
• ... and 74 more: https://git.openjdk.java.net/jdk/compare/b1725550a265c3ffb280969e1b8eabd12aa5bd65...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[YaSuenag]

The changes look good.

Thanks!

I think it would be best if the 2nd review came from the GC team.

I think so too, I'm waiting for the review from GC folks.

[stefank]

The HotSpot changes look good.

[YaSuenag]

/integrate

[openjdk]

@YaSuenag Since your change was applied there have been 110 commits pushed to the master branch:

• e828a93: 8261395: C1 crash "cannot make java calls from the native compiler"
• 3c47cab: 8261034: improve jcmd GC.class_histogram to support parallel
• ed32e02: 8241187: ToolBox::grep should allow for negative filtering
• cc03734: 8266925: Add a test to verify that hidden class's members are not statically invocable
• 271a0c7: 8047218: [TEST_BUG] java/awt/FullScreen/AltTabCrashTest/AltTabCrashTest.java fails with exception
• 1a0ff28: 8255035: Update BCEL to Version 6.5.0
• 57c6ba6: 8266822: Rename MetaspaceShared::is_old_class to be more explicit about what "old" means
• 616244f: 8266937: Remove Compile::reshape_address
• 974b9f7: 8266773: Release VM is broken with GCC 9 after 8214237
• f6c5a6b: 8266784: java/text/Collator/RuleBasedCollatorTest.java fails with jtreg 6
• ... and 100 more: https://git.openjdk.java.net/jdk/compare/b1725550a265c3ffb280969e1b8eabd12aa5bd65...master

Your commit was automatically rebased without conflicts.

Pushed as commit 476994a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.