8265528: Specification of BasicSplitPaneDivider::getMinimumSize,getPreferredSize doesn't match with its behavior.

[prsadhuk]

The current specification of these 2 methods
api/java.desktop/javax/swing/plaf/basic/BasicSplitPaneDivider.html#getPreferredSize().
and
api/java.desktop/javax/swing/plaf/basic/BasicSplitPaneDivider.html#getMinimumSize()
does not specify correct return values. Also, the spec is not very intuitive and clear.

Rectified the spec to specify correct behaviour.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8265528: Specification of BasicSplitPaneDivider::getMinimumSize,getPreferredSize doesn't match with its behavior.

Reviewers

• Alexander Zuev (@azuev-java - Reviewer) ⚠️ Review applies to 5e81609

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3870/head:pull/3870
$ git checkout pull/3870

Update a local copy of the PR:
$ git checkout pull/3870
$ git pull https://git.openjdk.java.net/jdk pull/3870/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3870

View PR using the GUI difftool:
$ git pr show -t 3870

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3870.diff

[bridgekeeper]

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prsadhuk The following label will be automatically applied to this pull request:

• swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (4fcc1ea1)
• 02: Full - Incremental (5e1a55cd)
• 01: Full - Incremental (eea67529)
• 00: Full (5e816095)

[openjdk]

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265528: Specification of BasicSplitPaneDivider::getMinimumSize,getPreferredSize doesn't match with its behavior.

Reviewed-by: kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 152 new commits pushed to the master branch:

• 476994a: 8266531: ZAddress::address() should be removed from SA
• e828a93: 8261395: C1 crash "cannot make java calls from the native compiler"
• 3c47cab: 8261034: improve jcmd GC.class_histogram to support parallel
• ed32e02: 8241187: ToolBox::grep should allow for negative filtering
• cc03734: 8266925: Add a test to verify that hidden class's members are not statically invocable
• 271a0c7: 8047218: [TEST_BUG] java/awt/FullScreen/AltTabCrashTest/AltTabCrashTest.java fails with exception
• 1a0ff28: 8255035: Update BCEL to Version 6.5.0
• 57c6ba6: 8266822: Rename MetaspaceShared::is_old_class to be more explicit about what "old" means
• 616244f: 8266937: Remove Compile::reshape_address
• 974b9f7: 8266773: Release VM is broken with GCC 9 after 8214237
• ... and 142 more: https://git.openjdk.java.net/jdk/compare/f86b70c391c2909676a7d9821b7367269aa85206...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[prsadhuk]

/csr

[openjdk]

@prsadhuk has indicated that a compatibility and specification (CSR) request is needed for this pull request.
@prsadhuk please create a CSR request for issue JDK-8265528. This pull request cannot be integrated until the CSR request is approved.

[prsadhuk]

/csr JDK-8266541

[openjdk]

@prsadhuk usage: /csr [needed|unneeded], requires that the issue the pull request refers to links to an approved CSR request.

[prsadhuk]

csr https://bugs.openjdk.java.net/browse/JDK-8266541

[prsadhuk]

/integrate

[openjdk]

@prsadhuk Since your change was applied there have been 166 commits pushed to the master branch:

• d215743: 8231031: runtime/ReservedStack/ReservedStackTest.java fails after jsr166 refresh
• ab17be2: 8252530: Fix inconsistencies in hotspot whitebox
• 2568d18: 8267047: Put serviceability/sa/TestJmapCoreMetaspace.java back on ZGC problem list due to JDK-8267045
• accbfea: 8226216: parameter modifiers are not visible to javac plugins across compilation boundaries
• 69daedf: 8266845: Shenandoah: Simplify SBS::load_reference_barrier implementation
• 7433821: 8250658: Performance of ClipFlatOval Renderperf test is very low
• 4727187: 8266567: Fix javadoc tag references in sun.management.jmxremote.ConnectorBootstrap
• 11759bf: 8266798: C1: More types of instruction can also apply LoopInvariantCodeMotion
• dcf250d: 8233378: CHT: Fast reset
• f3b510b: 8266923: [JVMCI] expose StackOverflow::_stack_overflow_limit to JVMCI
• ... and 156 more: https://git.openjdk.java.net/jdk/compare/f86b70c391c2909676a7d9821b7367269aa85206...master

Your commit was automatically rebased without conflicts.

Pushed as commit b50fc5f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.