Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8180568: Refactor javax/crypto shell tests to plain java tests #3876

Closed
wants to merge 1 commit into from

Conversation

sisahoo
Copy link
Member

@sisahoo sisahoo commented May 5, 2021

This change is to remove the shell Test and convert to it's java equivalent. That is the reason the shell Tests are deleted and the equivalent Java implementation provided.
The purpose of the Test TestExemption.java is with limited crypto policy a JCE provider can supplemented additional crypto permissions through "cryptoPerms" file bundled inside the JCE signed jar.
It also need to be noticed that TestExemption.java has '@requires java.runtime.name ~= "OpenJDK.*"'. It looks the intension of this Test availability in open GIT is to run by any other JDK providers.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8180568: Refactor javax/crypto shell tests to plain java tests

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3876/head:pull/3876
$ git checkout pull/3876

Update a local copy of the PR:
$ git checkout pull/3876
$ git pull https://git.openjdk.java.net/jdk pull/3876/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3876

View PR using the GUI difftool:
$ git pr show -t 3876

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3876.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 5, 2021

👋 Welcome back ssahoo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 5, 2021
@openjdk
Copy link

openjdk bot commented May 5, 2021

@sisahoo The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label May 5, 2021
@mlbridge
Copy link

mlbridge bot commented May 5, 2021

Webrevs

Copy link
Contributor

@bradfordwetmore bradfordwetmore left a comment

Looks good to me.

@openjdk
Copy link

openjdk bot commented May 5, 2021

@sisahoo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8180568: Refactor javax/crypto shell tests to plain java tests

Reviewed-by: wetmore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2267 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 5, 2021
@sisahoo
Copy link
Member Author

sisahoo commented May 6, 2021

/integrate

@openjdk openjdk bot closed this May 6, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 6, 2021
@openjdk
Copy link

openjdk bot commented May 6, 2021

@sisahoo Since your change was applied there have been 2267 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 20ad428.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
2 participants