Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253728: tests fail with "assert(fr.is_compiled_frame()) failed: Wrong frame type" #388

Closed
wants to merge 1 commit into from

Conversation

@phedlin
Copy link
Member

@phedlin phedlin commented Sep 28, 2020

Spurious assert (valid for Aarch64 only).

The frame may already be deoptimized.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253728: tests fail with "assert(fr.is_compiled_frame()) failed: Wrong frame type"

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/388/head:pull/388
$ git checkout pull/388

@phedlin phedlin changed the title 8253728: tests fail with "assert(fr.is_compiled_frame()) failed: Wrog frame type" 8253728: tests fail with "assert(fr.is_compiled_frame()) failed: Wrong frame type" Sep 28, 2020
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 28, 2020

👋 Welcome back phedlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Sep 28, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 28, 2020

@phedlin The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the hotspot label Sep 28, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 28, 2020

Webrevs

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 28, 2020

@phedlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253728: tests fail with "assert(fr.is_compiled_frame()) failed: Wrong frame type"

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 527b0e4: 8248984: Bump minimum boot jdk to JDK 15
  • ac15d64: 8241151: Incorrect lint warning for no definition of serialVersionUID in a record

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 28, 2020
@phedlin
Copy link
Member Author

@phedlin phedlin commented Sep 28, 2020

Thank you Vladimir.

Loading

@phedlin
Copy link
Member Author

@phedlin phedlin commented Sep 28, 2020

/integrate

Loading

@openjdk openjdk bot closed this Sep 28, 2020
@openjdk openjdk bot added integrated and removed ready labels Sep 28, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 28, 2020

@phedlin Since your change was applied there have been 2 commits pushed to the master branch:

  • 527b0e4: 8248984: Bump minimum boot jdk to JDK 15
  • ac15d64: 8241151: Incorrect lint warning for no definition of serialVersionUID in a record

Your commit was automatically rebased without conflicts.

Pushed as commit 70b0fcc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@openjdk openjdk bot removed the rfr label Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants