Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252758: Lanai: Optimize index calculation while copying glyphs #3883

Closed

Conversation

@jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented May 5, 2021

Loop optimization while copying glyph content.
J2DDemo, SwingSet2 and Font2DTest are green.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252758: Lanai: Optimize index calculation while copying glyphs

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3883/head:pull/3883
$ git checkout pull/3883

Update a local copy of the PR:
$ git checkout pull/3883
$ git pull https://git.openjdk.java.net/jdk pull/3883/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3883

View PR using the GUI difftool:
$ git pr show -t 3883

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3883.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 5, 2021

👋 Welcome back jdv! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 5, 2021

@jayathirthrao The following label will be automatically applied to this pull request:

  • 2d

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the 2d label May 5, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 5, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented May 6, 2021

@jayathirthrao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8252758: Lanai: Optimize index calculation while copying glyphs

Reviewed-by: aghaisas, pbansal

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 6, 2021
@jayathirthrao
Copy link
Member Author

@jayathirthrao jayathirthrao commented May 6, 2021

/integrate

@openjdk openjdk bot closed this May 6, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 6, 2021

@jayathirthrao Since your change was applied there have been 22 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 2438498.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jayathirthrao jayathirthrao deleted the JDK-8252758_glyph_index branch May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants