Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266561: Remove Compile::_save_argument_registers #3884

Closed
wants to merge 2 commits into from

Conversation

@cl4es
Copy link
Member

@cl4es cl4es commented May 5, 2021

Compile::_save_argument_registers is always false, so I suggest removing it.

It was used in the past for certain stubs, but the last use appears to have been removed with JDK-8136406


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266561: Remove Compile::_save_argument_registers

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3884/head:pull/3884
$ git checkout pull/3884

Update a local copy of the PR:
$ git checkout pull/3884
$ git pull https://git.openjdk.java.net/jdk pull/3884/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3884

View PR using the GUI difftool:
$ git pr show -t 3884

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3884.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 5, 2021

👋 Welcome back redestad! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented May 5, 2021

@cl4es The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot label May 5, 2021
@cl4es
Copy link
Member Author

@cl4es cl4es commented May 5, 2021

/label remove hotspot
/label add hotspot-compiler

@openjdk openjdk bot removed the hotspot label May 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 5, 2021

@cl4es
The hotspot label was successfully removed.

@openjdk
Copy link

@openjdk openjdk bot commented May 5, 2021

@cl4es
The hotspot-compiler label was successfully added.

@cl4es cl4es marked this pull request as ready for review May 5, 2021
@openjdk openjdk bot added the rfr label May 5, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 5, 2021

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

These are C2 changes and they look fine.

I thought we may do more clean up but C1 may pass must_gc_arguments to RuntimeStub::new_runtime_stub().

@openjdk
Copy link

@openjdk openjdk bot commented May 5, 2021

@cl4es This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266561: Remove Compile::_save_argument_registers

Reviewed-by: kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 177 new commits pushed to the master branch:

  • 47d4438: 8266426: ZHeapIteratorOopClosure does not handle native access properly
  • 2438498: 8252758: Lanai: Optimize index calculation while copying glyphs
  • eb3b96d: 8266496: WBIsKlassAliveClosure.do_klass() fails for hidden classes
  • 51f5adf: 8265047: Inconsistent warning message in jcmd VM.log
  • ea30bd6: 8263362: Avoid division by 0 in java/awt/font/TextJustifier.java justify
  • 0f9852c: 8266168: -Wmaybe-uninitialized happens in check_code.c
  • a86ee9b: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8
  • 2dd5667: 8266018: Shenandoah: fix an incorrect assert
  • 22ca62c: 8266542: Remove broken -XX:-UseLoopSafepoints flag
  • 7835cdb: 8265915: adjust state_unloading_cycle compuation order in nmethod::is_unloading
  • ... and 167 more: https://git.openjdk.java.net/jdk/compare/0a4c33826d0422af7c4cfa5f479fe0b6b0f83d23...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 5, 2021
@cl4es
Copy link
Member Author

@cl4es cl4es commented May 5, 2021

These are C2 changes and they look fine.

Thanks!

I thought we may do more clean up but C1 may pass must_gc_arguments to RuntimeStub::new_runtime_stub().

Yes, I started pulling at that thread, but it wasn't obvious if it would unravel nicely. And even if so it seemed more appropriate for a follow-up.

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good to me.

@cl4es
Copy link
Member Author

@cl4es cl4es commented May 6, 2021

@vnkozlov @TobiHartmann - thanks for reviewing!

/integrate

@openjdk openjdk bot closed this May 6, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 6, 2021

@cl4es Since your change was applied there have been 177 commits pushed to the master branch:

  • 47d4438: 8266426: ZHeapIteratorOopClosure does not handle native access properly
  • 2438498: 8252758: Lanai: Optimize index calculation while copying glyphs
  • eb3b96d: 8266496: WBIsKlassAliveClosure.do_klass() fails for hidden classes
  • 51f5adf: 8265047: Inconsistent warning message in jcmd VM.log
  • ea30bd6: 8263362: Avoid division by 0 in java/awt/font/TextJustifier.java justify
  • 0f9852c: 8266168: -Wmaybe-uninitialized happens in check_code.c
  • a86ee9b: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8
  • 2dd5667: 8266018: Shenandoah: fix an incorrect assert
  • 22ca62c: 8266542: Remove broken -XX:-UseLoopSafepoints flag
  • 7835cdb: 8265915: adjust state_unloading_cycle compuation order in nmethod::is_unloading
  • ... and 167 more: https://git.openjdk.java.net/jdk/compare/0a4c33826d0422af7c4cfa5f479fe0b6b0f83d23...master

Your commit was automatically rebased without conflicts.

Pushed as commit c665dba.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@cl4es cl4es deleted the save_argument_registers branch May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants