Skip to content

8266567: Fix javadoc tag references in sun.management.jmxremote.ConnectorBootstrap #3885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

pavelrappo
Copy link
Member

@pavelrappo pavelrappo commented May 5, 2021

This fixes two javadoc tag references and several typos. References are fixed by removing whitespace before the opening (. That whitespace caused the opening ( and the rest of the reference to be parsed as a link label.

Since we are here, I think this class could also benefit from using modern APIs. This should be done in a separate PR though. For example:

  1. Numerous instances of Boolean.valueOf( <var> ).booleanValue() could be changed to Boolean.parseBoolean( <var> )
  2. throw (IllegalArgumentException) new IllegalArgumentException(msg).initCause(e); could be changed to throw new IllegalArgumentException(msg, e);

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266567: Fix javadoc tag references in sun.management.jmxremote.ConnectorBootstrap

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3885/head:pull/3885
$ git checkout pull/3885

Update a local copy of the PR:
$ git checkout pull/3885
$ git pull https://git.openjdk.java.net/jdk pull/3885/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3885

View PR using the GUI difftool:
$ git pr show -t 3885

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3885.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 5, 2021

👋 Welcome back prappo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 5, 2021
@openjdk
Copy link

openjdk bot commented May 5, 2021

@pavelrappo The following labels will be automatically applied to this pull request:

  • jmx
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org jmx jmx-dev@openjdk.org labels May 5, 2021
@mlbridge
Copy link

mlbridge bot commented May 5, 2021

Webrevs

Copy link
Member

@dfuch dfuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing the various typos.

@openjdk
Copy link

openjdk bot commented May 5, 2021

@pavelrappo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266567: Fix javadoc tag references in sun.management.jmxremote.ConnectorBootstrap

Reviewed-by: dfuchs, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 104 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 5, 2021
@pavelrappo
Copy link
Member Author

pavelrappo commented May 5, 2021

Daniel, would you kindly review the most recent commit, which fixes three more typos?

Copy link
Contributor

@sspitsyn sspitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Pavel,
It looks good.
Just one nit is to add a dot at the end of this comment:
280 // time. It's OK for now as logic in Agent.java forbids multiple agents
Thanks,
Serguei

@pavelrappo
Copy link
Member Author

Just one nit is to add a dot at the end of this comment:
280 // time. It's OK for now as logic in Agent.java forbids multiple agents

I added two full stops: one for each unterminated sentence in that inline comment.

@pavelrappo
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this May 12, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 12, 2021
@openjdk
Copy link

openjdk bot commented May 12, 2021

@pavelrappo Since your change was applied there have been 104 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 4727187.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@pavelrappo pavelrappo deleted the 8266567 branch September 21, 2021 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated jmx jmx-dev@openjdk.org serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants