8266598: Exception values for AnnotationTypeMismatchException are not always informative

[raphw]

This improves the messages that are provided by AnnotationTypeMismatchExceptions. The message provided by AnnotationTypeMismatchExceptions is deliberately undefined such that this should not break any contract.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8266598: Exception values for AnnotationTypeMismatchException are not always informative

Reviewers

• Joel Borggrén-Franck (@jbf - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3892/head:pull/3892
$ git checkout pull/3892

Update a local copy of the PR:
$ git checkout pull/3892
$ git pull https://git.openjdk.java.net/jdk pull/3892/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3892

View PR using the GUI difftool:
$ git pr show -t 3892

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3892.diff

[bridgekeeper]

👋 Welcome back winterhalter! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@raphw The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (064334c4)
• 02: Full - Incremental (9acdb5d0)
• 01: Full - Incremental (57ab3721)
• 00: Full (5e61d239)

[jddarcy]

Please add 8266598 to the @bug lines of the regression tests.

[bridgekeeper]

@raphw This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[raphw]

Commenting on PR to avoid closing it, as it is still under review.

[jbf]

Link to CSR: https://bugs.openjdk.java.net/browse/JDK-8266768

[jbf]

@bug numbers are usually on the same line: "* @bug 8228988 8266598"

[jbf]

Same, here, single line

[raphw]

Moved the bug number to the same line on both tests.

[jbf]

LGTM

[jbf]

/csr

[openjdk]

@raphw This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266598: Exception values for AnnotationTypeMismatchException are not always informative

Reviewed-by: jfranck

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 512 new commits pushed to the master branch:

• 13d6180: 8264859: Implement Context-Specific Deserialization Filters
• dd34a4c: 8268372: ZGC: dynamically select the number of concurrent GC threads used
• 4388959: 8268056: Update java.net and java.nio to use switch expressions
• 9cfd560: 8267663: [vector] Add unsigned comparison operators on AArch64
• 4413142: 8268017: C2: assert(phi_type->isa_int() || phi_type->isa_ptr() || phi_type->isa_long()) failed: bad phi type
• 2bfd708: 8266557: assert(SafepointMechanism::local_poll_armed(_handshakee)) failed: Must be
• 4d1cf51: 8240349: jlink should not leave partial image output directory on failure
• 07108c9: 8268241: deprecate JVM TI Heap functions 1.0
• c9dbc4f: 8266891: Provide a switch to force the class space to a specific location
• 2cc1977: 8268424: JFR tests fail due to GC cause 'G1 Preventive Collection' not in the valid causes after JDK-8257774
• ... and 502 more: https://git.openjdk.java.net/jdk/compare/138d573c3567e9a51b1ac2b1de89b41c4b51ae93...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jddarcy, @jbf) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@jbf the issue for this pull request, JDK-8266598, already has an approved CSR request: JDK-8266768

[raphw]

/integrate

[openjdk]

@raphw
Your change (at version 064334c) is now ready to be sponsored by a Committer.

[jbf]

/sponsor

[openjdk]

@jbf @raphw Since your change was applied there have been 512 commits pushed to the master branch:

• 13d6180: 8264859: Implement Context-Specific Deserialization Filters
• dd34a4c: 8268372: ZGC: dynamically select the number of concurrent GC threads used
• 4388959: 8268056: Update java.net and java.nio to use switch expressions
• 9cfd560: 8267663: [vector] Add unsigned comparison operators on AArch64
• 4413142: 8268017: C2: assert(phi_type->isa_int() || phi_type->isa_ptr() || phi_type->isa_long()) failed: bad phi type
• 2bfd708: 8266557: assert(SafepointMechanism::local_poll_armed(_handshakee)) failed: Must be
• 4d1cf51: 8240349: jlink should not leave partial image output directory on failure
• 07108c9: 8268241: deprecate JVM TI Heap functions 1.0
• c9dbc4f: 8266891: Provide a switch to force the class space to a specific location
• 2cc1977: 8268424: JFR tests fail due to GC cause 'G1 Preventive Collection' not in the valid causes after JDK-8257774
• ... and 502 more: https://git.openjdk.java.net/jdk/compare/138d573c3567e9a51b1ac2b1de89b41c4b51ae93...master

Your commit was automatically rebased without conflicts.

Pushed as commit 7b1e402.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.