New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8266603: jpackage: Add missing copyright file in Java runtime .deb installers #3894
8266603: jpackage: Add missing copyright file in Java runtime .deb installers #3894
Conversation
👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into |
@alexeysemenyukoracle The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
7b2638b
to
796f655
Compare
/integrate |
@alexeysemenyukoracle This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 14 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@alexeysemenyukoracle Since your change was applied there have been 14 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit c8b7447. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
jpackage should create copyright file in /usr/share/doc directory tree when building .deb package for Java runtime with installation directory in /usr directory tree.
jpackage creates share/doc/copyright file in installation directory for apps installed outside of /usr tree.
jpackage creates /usr/share/doc/${package_name}/copyright file for apps installed in /usr tree .
jpackage doesn't create copyright file at all for Java runtime. The reason for this behavior was that jpackage should not place additional files in installation directory of Java runtime. However when installing Java runtime or app in /usr tree, copyright file will be placed outside of installation directory. Thus copyright file should be always created if package installation directory is inside of /usr tree.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3894/head:pull/3894
$ git checkout pull/3894
Update a local copy of the PR:
$ git checkout pull/3894
$ git pull https://git.openjdk.java.net/jdk pull/3894/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3894
View PR using the GUI difftool:
$ git pr show -t 3894
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3894.diff