Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266603: jpackage: Add missing copyright file in Java runtime .deb installers #3894

Closed

Conversation

alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented May 6, 2021

jpackage should create copyright file in /usr/share/doc directory tree when building .deb package for Java runtime with installation directory in /usr directory tree.

jpackage creates share/doc/copyright file in installation directory for apps installed outside of /usr tree.

jpackage creates /usr/share/doc/${package_name}/copyright file for apps installed in /usr tree .

jpackage doesn't create copyright file at all for Java runtime. The reason for this behavior was that jpackage should not place additional files in installation directory of Java runtime. However when installing Java runtime or app in /usr tree, copyright file will be placed outside of installation directory. Thus copyright file should be always created if package installation directory is inside of /usr tree.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266603: jpackage: Add missing copyright file in Java runtime .deb installers

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3894/head:pull/3894
$ git checkout pull/3894

Update a local copy of the PR:
$ git checkout pull/3894
$ git pull https://git.openjdk.java.net/jdk pull/3894/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3894

View PR using the GUI difftool:
$ git pr show -t 3894

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3894.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 6, 2021

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented May 6, 2021

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs rfr labels May 6, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 7, 2021

Webrevs

@alexeysemenyukoracle
Copy link
Member Author

@alexeysemenyukoracle alexeysemenyukoracle commented May 10, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented May 10, 2021

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266603: jpackage: Add missing copyright file in Java runtime .deb installers

Reviewed-by: almatvee, herrick

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • c494efc: 8266774: System property values for stdout/err on Windows UTF-8
  • 25d99e5: 8266330: itableMethodEntry::initialize() asserts with archived old classes
  • 5d761fc: 8266796: Clean up the unnecessary code in the method UnsharedNameTable#fromUtf
  • e41fd73: 8266252: Streamline AbstractInterpreter::method_kind
  • b823b3e: 8266797: Fix for 8266610 breaks the build on macos
  • 53db2a0: 8226384: Implement a better logic to switch between OpenGL and Metal pipeline
  • 1603ca2: 8241248: NullPointerException in sun.security.ssl.HKDF.extract(HKDF.java:93)
  • 0f925d1: 8266015: Implement AdapterHandlerLibrary lookup fast-path for common adapters
  • 69b96f9: 8266610: Method RandomAccessFile#length() returns 0 for block devices on linux.
  • 9b76955: 8266249: javax/swing/JPopupMenu/7156657/bug7156657.java fails on macOS
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/0790e6016e153b4fa4df5d80737f90aa555c7ba9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 10, 2021
@openjdk openjdk bot closed this May 10, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 10, 2021

@alexeysemenyukoracle Since your change was applied there have been 14 commits pushed to the master branch:

  • c494efc: 8266774: System property values for stdout/err on Windows UTF-8
  • 25d99e5: 8266330: itableMethodEntry::initialize() asserts with archived old classes
  • 5d761fc: 8266796: Clean up the unnecessary code in the method UnsharedNameTable#fromUtf
  • e41fd73: 8266252: Streamline AbstractInterpreter::method_kind
  • b823b3e: 8266797: Fix for 8266610 breaks the build on macos
  • 53db2a0: 8226384: Implement a better logic to switch between OpenGL and Metal pipeline
  • 1603ca2: 8241248: NullPointerException in sun.security.ssl.HKDF.extract(HKDF.java:93)
  • 0f925d1: 8266015: Implement AdapterHandlerLibrary lookup fast-path for common adapters
  • 69b96f9: 8266610: Method RandomAccessFile#length() returns 0 for block devices on linux.
  • 9b76955: 8266249: javax/swing/JPopupMenu/7156657/bug7156657.java fails on macOS
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/0790e6016e153b4fa4df5d80737f90aa555c7ba9...master

Your commit was automatically rebased without conflicts.

Pushed as commit c8b7447.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs integrated
3 participants