Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8266044: Nested class summary should show kind of class or interface #3897

Closed
wants to merge 1 commit into from

Conversation

hns
Copy link
Member

@hns hns commented May 6, 2021

This is a simple fix to display the actual kind of nested class in the nested class summary table. This is not using Utils#getTypeElementKindName since we want to display the signature-like source level kind name (e.g. "enum" rather than "enum class").


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266044: Nested class summary should show kind of class or interface

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3897/head:pull/3897
$ git checkout pull/3897

Update a local copy of the PR:
$ git checkout pull/3897
$ git pull https://git.openjdk.java.net/jdk pull/3897/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3897

View PR using the GUI difftool:
$ git pr show -t 3897

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3897.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 6, 2021

👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 6, 2021
@openjdk
Copy link

openjdk bot commented May 6, 2021

@hns The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the javadoc javadoc-dev@openjdk.org label May 6, 2021
@mlbridge
Copy link

mlbridge bot commented May 6, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented May 6, 2021

@hns This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266044: Nested class summary should show kind of class or interface

Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • e840597: 8266460: java.io tests fail on null stream with upgraded jtreg/TestNG
  • fcedfc8: 8266579: Update test/jdk/java/lang/ProcessHandle/PermissionTest.java & test/jdk/java/sql/testng/util/TestPolicy.java
  • c665dba: 8266561: Remove Compile::_save_argument_registers
  • 47d4438: 8266426: ZHeapIteratorOopClosure does not handle native access properly
  • 2438498: 8252758: Lanai: Optimize index calculation while copying glyphs
  • eb3b96d: 8266496: WBIsKlassAliveClosure.do_klass() fails for hidden classes
  • 51f5adf: 8265047: Inconsistent warning message in jcmd VM.log
  • ea30bd6: 8263362: Avoid division by 0 in java/awt/font/TextJustifier.java justify
  • 0f9852c: 8266168: -Wmaybe-uninitialized happens in check_code.c
  • a86ee9b: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8
  • ... and 1 more: https://git.openjdk.java.net/jdk/compare/22ca62c2cb61940dd7b1028925cd651ffdf80690...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 6, 2021
@hns
Copy link
Member Author

hns commented May 6, 2021

/integrate

@openjdk openjdk bot closed this May 6, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 6, 2021
@openjdk
Copy link

openjdk bot commented May 6, 2021

@hns Since your change was applied there have been 11 commits pushed to the master branch:

  • e840597: 8266460: java.io tests fail on null stream with upgraded jtreg/TestNG
  • fcedfc8: 8266579: Update test/jdk/java/lang/ProcessHandle/PermissionTest.java & test/jdk/java/sql/testng/util/TestPolicy.java
  • c665dba: 8266561: Remove Compile::_save_argument_registers
  • 47d4438: 8266426: ZHeapIteratorOopClosure does not handle native access properly
  • 2438498: 8252758: Lanai: Optimize index calculation while copying glyphs
  • eb3b96d: 8266496: WBIsKlassAliveClosure.do_klass() fails for hidden classes
  • 51f5adf: 8265047: Inconsistent warning message in jcmd VM.log
  • ea30bd6: 8263362: Avoid division by 0 in java/awt/font/TextJustifier.java justify
  • 0f9852c: 8266168: -Wmaybe-uninitialized happens in check_code.c
  • a86ee9b: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8
  • ... and 1 more: https://git.openjdk.java.net/jdk/compare/22ca62c2cb61940dd7b1028925cd651ffdf80690...master

Your commit was automatically rebased without conflicts.

Pushed as commit 2dcbedf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org
2 participants