New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8266044: Nested class summary should show kind of class or interface #3897
Conversation
|
@hns This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 11 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
/integrate |
@hns Since your change was applied there have been 11 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 2dcbedf. |
This is a simple fix to display the actual kind of nested class in the nested class summary table. This is not using
Utils#getTypeElementKindName
since we want to display the signature-like source level kind name (e.g. "enum" rather than "enum class").Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3897/head:pull/3897
$ git checkout pull/3897
Update a local copy of the PR:
$ git checkout pull/3897
$ git pull https://git.openjdk.java.net/jdk pull/3897/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3897
View PR using the GUI difftool:
$ git pr show -t 3897
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3897.diff