Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252844: Update check configuration to Skara format #39

Closed
wants to merge 2 commits into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Sep 7, 2020

Now that the JDK main-line repository is using the Skara tooling, the jcheck configuration file should be updated to the new format.

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252844: Update check configuration to Skara format

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/39/head:pull/39
$ git checkout pull/39

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 7, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8252844 8252844: Update check configuration to Skara format Sep 7, 2020
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 7, 2020
@openjdk
Copy link

openjdk bot commented Sep 7, 2020

@rwestberg The following label will be automatically applied to this pull request: build.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Sep 7, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 7, 2020

Webrevs

.jcheck/conf Outdated Show resolved Hide resolved
Co-authored-by: Erik Duveblad <erik.helin@oracle.com>
Copy link
Member

@edvbld edvbld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@openjdk
Copy link

openjdk bot commented Sep 7, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8252844: Update check configuration to Skara format

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch:

  • cc5039e: 8252837: Cleanup SAP Copyright file headers
  • 55c7e76: 8252825: Add automated test for fix done in JDK-8218479

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate cc5039e19e38c60b037eaab8fc42c0e77296d8a0.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 7, 2020
@rwestberg
Copy link
Member Author

Thanks for reviewing Erik! As this is blocking other pull requests from completing, I plan to integrate it right away.

@rwestberg
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Sep 7, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 7, 2020
@openjdk
Copy link

openjdk bot commented Sep 7, 2020

@rwestberg Since your change was applied there have been 2 commits pushed to the master branch:

  • cc5039e: 8252837: Cleanup SAP Copyright file headers
  • 55c7e76: 8252825: Add automated test for fix done in JDK-8218479

Your commit was automatically rebased without conflicts.

Pushed as commit e0c8d44.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

caojoshua pushed a commit to caojoshua/jdk that referenced this pull request May 24, 2023
* Add +PrintOptoStatistics to tests.

* some clean-up

---------

Co-authored-by: Xin Liu <xxinliu@amazon.com>
robehn pushed a commit to robehn/jdk that referenced this pull request Aug 15, 2023
It would previously fail on merge-tree which expects two branches and no
tags.

Also rename the merge branch to `merge-<tag>` so that we can support
merging multiple tags in parallel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
2 participants