New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8252844: Update check configuration to Skara format #39
Conversation
👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into |
@rwestberg The following label will be automatically applied to this pull request: When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the |
Webrevs
|
Co-authored-by: Erik Duveblad <erik.helin@oracle.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type
Since the source branch of this PR was last updated there have been 2 commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge ➡️ To integrate this PR with the above commit message to the |
Thanks for reviewing Erik! As this is blocking other pull requests from completing, I plan to integrate it right away. |
/integrate |
@rwestberg Since your change was applied there have been 2 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit e0c8d44. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
* Add +PrintOptoStatistics to tests. * some clean-up --------- Co-authored-by: Xin Liu <xxinliu@amazon.com>
It would previously fail on merge-tree which expects two branches and no tags. Also rename the merge branch to `merge-<tag>` so that we can support merging multiple tags in parallel.
Now that the JDK main-line repository is using the Skara tooling, the jcheck configuration file should be updated to the new format.
Best regards,
Robin
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/39/head:pull/39
$ git checkout pull/39