-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8253748: StressIGV tests fail with release VMs #390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/issue add JDK-8253748 |
👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into |
@DamonFool This issue is referenced in the PR title - it will now be updated. |
/label add hotspot-compiler |
@DamonFool The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@DamonFool The |
@DamonFool The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and trivial.
@DamonFool This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Thanks @TobiHartmann for your review. |
@DamonFool Pushed as commit 9c17a35. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The following StressIGV tests fails with release VMs
The reason is that VM option 'StressIGVN' is diagnostic and must be enabled via -XX:+UnlockDiagnosticVMOptions.
The fix adds '-XX:+UnlockDiagnosticVMOptions' option.
And compiler/debug/TestStressIGVN.java should be only available for debug VMs since it depends on -XX:+TraceIterativeGVN.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/390/head:pull/390
$ git checkout pull/390