Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266440: Shenandoah: TestReferenceShortcutCycle.java test failed on AArch64 #3902

Closed
wants to merge 3 commits into from

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented May 6, 2021

JDK-8263427 missed corresponding changes for aarch64.

LRB needs to be enabled during weak roots/references processing, regardless if heap is stable.

Test:

  • hotspot_gc_shenandoah on Macosx/AArch64
  • hotspot_gc_shenandoah on Linux 64/AArch64

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266440: Shenandoah: TestReferenceShortcutCycle.java test failed on AArch64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3902/head:pull/3902
$ git checkout pull/3902

Update a local copy of the PR:
$ git checkout pull/3902
$ git pull https://git.openjdk.java.net/jdk pull/3902/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3902

View PR using the GUI difftool:
$ git pr show -t 3902

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3902.diff

Zhengyu Gu added 2 commits May 6, 2021 08:10
@bridgekeeper
Copy link

bridgekeeper bot commented May 6, 2021

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@zhengyu123
Copy link
Contributor Author

/add aarch64-port-dev

@openjdk openjdk bot added the rfr Pull request is ready for review label May 6, 2021
@openjdk
Copy link

openjdk bot commented May 6, 2021

@zhengyu123 Unknown command add - for a list of valid commands use /help.

@openjdk
Copy link

openjdk bot commented May 6, 2021

@zhengyu123 The following labels will be automatically applied to this pull request:

  • hotspot
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot hotspot-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels May 6, 2021
@zhengyu123
Copy link
Contributor Author

/label add aarch64-port-dev

@openjdk
Copy link

openjdk bot commented May 6, 2021

@zhengyu123 The label aarch64-port is not a valid label. These labels are valid:

  • serviceability
  • hotspot
  • sound
  • hotspot-compiler
  • kulla
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • 2d
  • security
  • swing
  • hotspot-runtime
  • jmx
  • build
  • nio
  • beans
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr
  • awt

@mlbridge
Copy link

mlbridge bot commented May 6, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented May 10, 2021

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266440: Shenandoah: TestReferenceShortcutCycle.java test failed on AArch64

Reviewed-by: aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 54 new commits pushed to the master branch:

  • 1603ca2: 8241248: NullPointerException in sun.security.ssl.HKDF.extract(HKDF.java:93)
  • 0f925d1: 8266015: Implement AdapterHandlerLibrary lookup fast-path for common adapters
  • 69b96f9: 8266610: Method RandomAccessFile#length() returns 0 for block devices on linux.
  • 9b76955: 8266249: javax/swing/JPopupMenu/7156657/bug7156657.java fails on macOS
  • 3af4efd: 8265291: Error in Javadoc for doAccessibleAction API in AccessibleJSlider class
  • be4f25b: 8266369: (se) Add wepoll based Selector
  • ff77ca8: 8266675: Optimize IntHashTable for encapsulation and ease of use
  • 04fad70: 8266765: [BACKOUT] JDK-8255493 Support for pre-generated java.lang.invoke classes in CDS dynamic archive
  • 0790e60: 8196743: jstatd doesn't see new Java processes inside Docker container
  • c6aa8f1: 8232644: bugs in serialized-form.html
  • ... and 44 more: https://git.openjdk.java.net/jdk/compare/61bb6eca3e34b3f8382614edccd167f7ecefba65...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 10, 2021
@zhengyu123
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this May 10, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 10, 2021
@openjdk
Copy link

openjdk bot commented May 10, 2021

@zhengyu123 Since your change was applied there have been 62 commits pushed to the master branch:

  • de78431: 8241502: C2: Migrate x86_64.ad to MacroAssembler
  • c8b7447: 8266603: jpackage: Add missing copyright file in Java runtime .deb installers
  • c494efc: 8266774: System property values for stdout/err on Windows UTF-8
  • 25d99e5: 8266330: itableMethodEntry::initialize() asserts with archived old classes
  • 5d761fc: 8266796: Clean up the unnecessary code in the method UnsharedNameTable#fromUtf
  • e41fd73: 8266252: Streamline AbstractInterpreter::method_kind
  • b823b3e: 8266797: Fix for 8266610 breaks the build on macos
  • 53db2a0: 8226384: Implement a better logic to switch between OpenGL and Metal pipeline
  • 1603ca2: 8241248: NullPointerException in sun.security.ssl.HKDF.extract(HKDF.java:93)
  • 0f925d1: 8266015: Implement AdapterHandlerLibrary lookup fast-path for common adapters
  • ... and 52 more: https://git.openjdk.java.net/jdk/compare/61bb6eca3e34b3f8382614edccd167f7ecefba65...master

Your commit was automatically rebased without conflicts.

Pushed as commit f78440a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@zhengyu123 zhengyu123 deleted the JDK-8266440-lrb-aarch64 branch October 27, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated shenandoah shenandoah-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants