-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8266646: Add more diagnostic to java/lang/System/LoggerFinder/modules #3904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could those be replaced with just Instant.now()
? Instant.toString()
uses the same formatter as ISO_INSTANT
.
Oh - good point Naoto! Thanks for the suggestion. Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I guess you could also remove DateTimeFormatter
import statement now.
@dfuch This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Doh. Done. |
/integrate |
@dfuch Since your change was applied there have been 18 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 3fcdc50. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi, please find here a trivial test change that adds some diagnostic (time stamps) to the LoggerFinder/modules subprocess test logs.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3904/head:pull/3904
$ git checkout pull/3904
Update a local copy of the PR:
$ git checkout pull/3904
$ git pull https://git.openjdk.java.net/jdk pull/3904/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3904
View PR using the GUI difftool:
$ git pr show -t 3904
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3904.diff