Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266646: Add more diagnostic to java/lang/System/LoggerFinder/modules #3904

Closed
wants to merge 3 commits into from

Conversation

dfuch
Copy link
Member

@dfuch dfuch commented May 6, 2021

Hi, please find here a trivial test change that adds some diagnostic (time stamps) to the LoggerFinder/modules subprocess test logs.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266646: Add more diagnostic to java/lang/System/LoggerFinder/modules

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3904/head:pull/3904
$ git checkout pull/3904

Update a local copy of the PR:
$ git checkout pull/3904
$ git pull https://git.openjdk.java.net/jdk pull/3904/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3904

View PR using the GUI difftool:
$ git pr show -t 3904

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3904.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 6, 2021

👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 6, 2021
@openjdk
Copy link

openjdk bot commented May 6, 2021

@dfuch The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label May 6, 2021
@mlbridge
Copy link

mlbridge bot commented May 6, 2021

Webrevs

Copy link
Member

@naotoj naotoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could those be replaced with just Instant.now()? Instant.toString() uses the same formatter as ISO_INSTANT.

@dfuch
Copy link
Member Author

dfuch commented May 6, 2021

Oh - good point Naoto! Thanks for the suggestion. Done.

Copy link
Member

@naotoj naotoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I guess you could also remove DateTimeFormatter import statement now.

@openjdk
Copy link

openjdk bot commented May 6, 2021

@dfuch This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266646: Add more diagnostic to java/lang/System/LoggerFinder/modules

Reviewed-by: naoto, iris, bpb, lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • a90b33a: 8266573: Make sure blackholes are tagged for all JVMCI paths

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 6, 2021
@dfuch
Copy link
Member Author

dfuch commented May 6, 2021

Doh. Done.

@dfuch
Copy link
Member Author

dfuch commented May 7, 2021

/integrate

@openjdk openjdk bot closed this May 7, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 7, 2021
@openjdk
Copy link

openjdk bot commented May 7, 2021

@dfuch Since your change was applied there have been 18 commits pushed to the master branch:

  • 9a19a0c: 8264760: JVM crashes when two threads encounter the same resolution error
  • 14f0afe: 8214237: Join parallel phases post evacuation
  • 2798b0d: 8266349: Pass down requested page size to reserve_memory_special
  • e0c8688: 8262992: Improve @see output
  • d2b5350: 8263507: Improve structure of package summary pages
  • a65021e: 8266618: Remove broken -XX:-OptoRemoveUseless
  • 94c6177: 8266536: Provide a variant of os::iso8601_time which works with arbitrary timestamps
  • 71b8ad4: 8266609: AArch64: include FP/LR space in LIR_Assembler::initial_frame_size_in_bytes()
  • ebb68d2: 8049700: Deprecate obsolete classes and methods in javax/swing/plaf/basic
  • 3a474d9: 8265612: revise the help info for jmap histo command
  • ... and 8 more: https://git.openjdk.java.net/jdk/compare/2dcbedf92a31da55299607c006821f22cc72ac0a...master

Your commit was automatically rebased without conflicts.

Pushed as commit 3fcdc50.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
5 participants