8266225: jarsigner is using incorrect security property to show weakness of certs

[haimaychao]

Please review the change to jarsigner so it uses certpath security property in order to properly display the weakness of the certificate algorithms.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8266225: jarsigner is using incorrect security property to show weakness of certs

Reviewers

• Weijun Wang (@wangweij - Reviewer)
• Sean Mullan (@seanjmullan - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3905/head:pull/3905
$ git checkout pull/3905

Update a local copy of the PR:
$ git checkout pull/3905
$ git pull https://git.openjdk.java.net/jdk pull/3905/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3905

View PR using the GUI difftool:
$ git pr show -t 3905

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3905.diff

[bridgekeeper]

👋 Welcome back hchao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@haimaychao The following labels will be automatically applied to this pull request:

• compiler
• core-libs
• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (533a7fed)
• 00: Full (1d37f99e)

[wangweij]

/label remove core-libs compiler

[openjdk]

@wangweij
The core-libs label was successfully removed.

The compiler label was successfully removed.

[wangweij]

What does the test show before this fix?

I don't see Security.setProperty called or a new java.security file is used. If jdk.jar.dA and jdk.certpath.dA are the same, then there's no way to find out if the new code works.

[haimaychao]

Added test using new java.security with different disabledAlgorithms for certpath and jar.

[openjdk]

@haimaychao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266225: jarsigner is using incorrect security property to show weakness of certs

Reviewed-by: weijun, mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 79 new commits pushed to the master branch:

• 0a12605: 8265448: (zipfs): Reduce read contention in ZipFileSystem
• acf02ed: 8208237: Re-examine defmeth tests and update as needed
• ac0287f: 8266770: Clean pending exception before running dynamic CDS dump
• 7a0a57c: 8266820: micro java/nio/SelectorWakeup.java has wrong copyright header
• d0daa72: 8266857: PipedOutputStream.sink should be volatile
• 381de0c: 8266753: jdk/test/lib/process/ProcTest.java failed with "Exception: Proc abnormal end"
• 2d2cd78: 8266761: AssertionError in sun.net.httpserver.ServerImpl.responseCompleted
• 9c9c47e: 8266813: Shenandoah: Use shorter instruction sequence for checking if marking in progress
• 0344e75: 8266794: Remove dead code notify_allocation_jvmti_allocation_event
• 9e6e222: 8266892: avoid maybe-uninitialized gcc warnings on linux s390x
• ... and 69 more: https://git.openjdk.java.net/jdk/compare/138d573c3567e9a51b1ac2b1de89b41c4b51ae93...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[haimaychao]

@wangweij @seanjmullan Thanks for the review.

[haimaychao]

/integrate

[openjdk]

@haimaychao Since your change was applied there have been 79 commits pushed to the master branch:

• 0a12605: 8265448: (zipfs): Reduce read contention in ZipFileSystem
• acf02ed: 8208237: Re-examine defmeth tests and update as needed
• ac0287f: 8266770: Clean pending exception before running dynamic CDS dump
• 7a0a57c: 8266820: micro java/nio/SelectorWakeup.java has wrong copyright header
• d0daa72: 8266857: PipedOutputStream.sink should be volatile
• 381de0c: 8266753: jdk/test/lib/process/ProcTest.java failed with "Exception: Proc abnormal end"
• 2d2cd78: 8266761: AssertionError in sun.net.httpserver.ServerImpl.responseCompleted
• 9c9c47e: 8266813: Shenandoah: Use shorter instruction sequence for checking if marking in progress
• 0344e75: 8266794: Remove dead code notify_allocation_jvmti_allocation_event
• 9e6e222: 8266892: avoid maybe-uninitialized gcc warnings on linux s390x
• ... and 69 more: https://git.openjdk.java.net/jdk/compare/138d573c3567e9a51b1ac2b1de89b41c4b51ae93...master

Your commit was automatically rebased without conflicts.

Pushed as commit 995e956.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.