8266610: Method RandomAccessFile#length() returns 0 for block devices on linux.

[vyommani]

RandomAccessFile.length() method for block device return always 0

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8266610: Method RandomAccessFile#length() returns 0 for block devices on linux.

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)
• Brian Burkhalter (@bplb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3914/head:pull/3914
$ git checkout pull/3914

Update a local copy of the PR:
$ git checkout pull/3914
$ git pull https://git.openjdk.java.net/jdk pull/3914/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3914

View PR using the GUI difftool:
$ git pr show -t 3914

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3914.diff

[bridgekeeper]

👋 Welcome back vtewari! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vyommani The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (72beb715)
• 00: Full (8f348ef9)

[AlanBateman]

I think this look okay, and consistent with the file dispatcher implementation.

[openjdk]

@vyommani This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266610: Method RandomAccessFile#length() returns 0 for block devices on linux.

Reviewed-by: alanb, bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1236 new commits pushed to the master branch:

• 0790e60: 8196743: jstatd doesn't see new Java processes inside Docker container
• c6aa8f1: 8232644: bugs in serialized-form.html
• b5b3119: 8266589: (fs) Improve performance of Files.copy() on macOS using copyfile(3)
• 947d69d: 8265042: javadoc HTML files not generated for types nested in records
• 946b0fe: 8266645: javac should not check for sealed supertypes in intersection types
• 74fecc0: 8266503: [UL] Make Decorations safely copy-able and reduce their size
• 86b8dc9: 8265426: Update java.security to use instanceof pattern variable
• 3fcdc50: 8266646: Add more diagnostic to java/lang/System/LoggerFinder/modules
• 9a19a0c: 8264760: JVM crashes when two threads encounter the same resolution error
• 14f0afe: 8214237: Join parallel phases post evacuation
• ... and 1226 more: https://git.openjdk.java.net/jdk/compare/34ae7aeb64db90dcb4d2f3d4acb16c714a32824f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bplb]

Covers updated FileInputStream as well (JDK-8264777).

[huishi-hs]

Could required os = linux added for test/jdk/java/nio/channels/FileChannel/BlockDeviceSize.java? As it is decribed only run as linux.

[vyommani]

Could required os = linux added for test/jdk/java/nio/channels/FileChannel/BlockDeviceSize.java? As it is decribed only run as linux.

Sure, this is separate issue(https://bugs.openjdk.java.net/browse/JDK-8150539). We will fix it separately.

[AlanBateman]

Could required os = linux added for test/jdk/java/nio/channels/FileChannel/BlockDeviceSize.java? As it is decribed only run as linux.

Yes, good idea. Also maybe we can see about changing it to avoid the dependency on /dev/sda1.

[vyommani]

Could required os = linux added for test/jdk/java/nio/channels/FileChannel/BlockDeviceSize.java? As it is decribed only run as linux.

Sure, this is separate issue(https://bugs.openjdk.java.net/browse/JDK-8150539). We will fix it separately.

[vyommani]

/integrate

[openjdk]

@vyommani Since your change was applied there have been 1241 commits pushed to the master branch:

• 9b76955: 8266249: javax/swing/JPopupMenu/7156657/bug7156657.java fails on macOS
• 3af4efd: 8265291: Error in Javadoc for doAccessibleAction API in AccessibleJSlider class
• be4f25b: 8266369: (se) Add wepoll based Selector
• ff77ca8: 8266675: Optimize IntHashTable for encapsulation and ease of use
• 04fad70: 8266765: [BACKOUT] JDK-8255493 Support for pre-generated java.lang.invoke classes in CDS dynamic archive
• 0790e60: 8196743: jstatd doesn't see new Java processes inside Docker container
• c6aa8f1: 8232644: bugs in serialized-form.html
• b5b3119: 8266589: (fs) Improve performance of Files.copy() on macOS using copyfile(3)
• 947d69d: 8265042: javadoc HTML files not generated for types nested in records
• 946b0fe: 8266645: javac should not check for sealed supertypes in intersection types
• ... and 1231 more: https://git.openjdk.java.net/jdk/compare/34ae7aeb64db90dcb4d2f3d4acb16c714a32824f...master

Your commit was automatically rebased without conflicts.

Pushed as commit 69b96f9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[dholmes-ora]

@vyommani this has broken the build on macos as you are including a linux specific header file in non-linux code! Please backout or fix ASAP. Thanks.

[vyommani]

I am working on it. i will provide fix ASAP.