Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266740: Shenandoah: Heap region count calculation still wrong after JDK-8265239 #3922

Closed

Conversation

@zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented May 7, 2021

JDK-8265239 only addressed heap size that needed to be aligned to region size, it did not address the adjustment needed when use large page.

To avoid all the complication, I purpose to defer region count calculation until heap size adjustment is done.

Test:

  • hotspot_gc_shenandoah
  • runtime/os/TestTracePageSizes.java now passed

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266740: Shenandoah: Heap region count calculation still wrong after JDK-8265239

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3922/head:pull/3922
$ git checkout pull/3922

Update a local copy of the PR:
$ git checkout pull/3922
$ git pull https://git.openjdk.java.net/jdk pull/3922/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3922

View PR using the GUI difftool:
$ git pr show -t 3922

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3922.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 7, 2021

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 7, 2021

@zhengyu123 The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 7, 2021

Webrevs

@zhengyu123 zhengyu123 closed this May 10, 2021
@zhengyu123
Copy link
Contributor Author

@zhengyu123 zhengyu123 commented May 10, 2021

A duplicate of JDK-8266802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant