-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8266761: AssertionError in sun.net.httpserver.ServerImpl.responseCompleted #3923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into |
Webrevs
|
@dfuch This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 51 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
@dfuch Since your change was applied there have been 57 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 2d2cd78. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi,
Please find here a fix to prevent an assertion error from firing in the com.sun.net.httpserver.
The issue occurs systematically when all of these conditions are met:
The test fails with the assertion error when run without the fix (provided system assertions are enabled) and passes with the fix.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3923/head:pull/3923
$ git checkout pull/3923
Update a local copy of the PR:
$ git checkout pull/3923
$ git pull https://git.openjdk.java.net/jdk pull/3923/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3923
View PR using the GUI difftool:
$ git pr show -t 3923
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3923.diff